linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] sh: sh7724.h: bugfix: remove unused clock index
Date: Thu, 24 Nov 2011 07:01:16 +0000	[thread overview]
Message-ID: <20111124070116.GA32112@linux-sh.org> (raw)
In-Reply-To: <87y5v8yi8p.wl%kuninori.morimoto.gx@renesas.com>

On Mon, Nov 21, 2011 at 06:59:54PM -0800, Kuninori Morimoto wrote:
> Current sh clocks are using pm_runtime frame work instead of old hwblk.
> So, HWBLK_UNKNOWN and HWBLK_DBG are not needed for now.
> 
> Now mstp32 clocks are registered by sh_clk_mstp32_register(),
> but the clock which isn't defined by SH_CLK_MSTP32() macro
> will be crash. because it doesn't have enable_reg.

On Mon, Nov 21, 2011 at 07:00:04PM -0800, Kuninori Morimoto wrote:
> Current sh clocks are using pm_runtime frame work instead of old hwblk.
> So, HWBLK_UNKNOWN, HWBLK_DBG and HWBLK_SUBC are not needed for now.
> 
> Now mstp32 clocks are registered by sh_clk_mstp32_register(),
> but the clock which isn't defined by SH_CLK_MSTP32() macro
> will be crash. because it doesn't have enable_reg.

On Wed, Nov 23, 2011 at 10:53:46PM +0100, Guennadi Liakhovetski wrote:
> Unused indices produce empty entries in the clock array, which then lead to
> Oopses at boot-time.

All applied to sh/hwblk, thanks.

      reply	other threads:[~2011-11-24  7:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-22  2:59 [PATCH 1/2] sh: sh7724.h: bugfix: remove unused clock index Kuninori Morimoto
2011-11-24  7:01 ` Paul Mundt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111124070116.GA32112@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).