From: Paul Mundt <lethal@linux-sh.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: Kota2 mach-type update fix
Date: Thu, 24 Nov 2011 08:23:42 +0000 [thread overview]
Message-ID: <20111124082342.GD32112@linux-sh.org> (raw)
In-Reply-To: <CANqRtoTvMpivHN0tZVTEY6SfkBrNLpu=rkRXUXKJG4J0UNCzhg@mail.gmail.com>
On Tue, Nov 22, 2011 at 08:41:57PM +0900, Magnus Damm wrote:
> On Tue, Nov 22, 2011 at 6:26 PM, Paul Mundt <lethal@linux-sh.org> wrote:
> > On Tue, Nov 22, 2011 at 03:08:57PM +0900, Magnus Damm wrote:
> >> From: Magnus Damm <damm@opensource.se>
> >>
> >> This patch adds kota2 to the in-kernel ARM mach-type file.
> >>
> >> Basic board support is included in 3.2-rc and the mach-type
> >> has been registered in the ARM machine repository as
> >>
> >> 3616 Renesas SH-Mobile kota2.x Board kota2 Yusuke Goda mainlined
> >>
> >> The file arch/arm/tools/mach-types is however missing Kota2
> >> which makes build of sh73a0 based boards fail with:
> >>
> >> arch/arm/mach-shmobile/platsmp.c: In function 'shmobile_smp_get_core_count':
> >> arch/arm/mach-shmobile/platsmp.c:28:2: error: implicit declaration of function 'machine_is_kota2'
> >> make[1]: *** [arch/arm/mach-shmobile/platsmp.o] Error 1
> >>
> >> arch/arm/mach-shmobile/board-kota2.c:448:136: error: 'MACH_TYPE_KOTA2' undeclared here (not in a function)
> >> make[1]: *** [arch/arm/mach-shmobile/board-kota2.o] Error 1
> >> make: *** [arch/arm/mach-shmobile] Error 2
> >>
> >> Signed-off-by: Magnus Damm <damm@opensource.se>
> >> ---
> >>
> >> ?I propose that Paul Mundt merges this patch together with other
> >> ?SH-Mobile ARM related fixes.
> >>
> > Err, no. I'm not patching machine-generated files which precisely say not
> > to patch them at the top of the file. If there is a missing definition
> > for an upstream board then the file needs to be regenerated with the new
> > definitions, plain and simple.
>
> Following the comment sure sounds like a good idea, but according to
> the git logs people seem to update the file:
>
> 1d08fd9 Update Nook Color machine 3284 to common Encore name
>
> Russell, do you mind if we update the mach-type file to include Kota2?
> It's already registered via the web interface.
>
I'll add it with Russell's Acked-by, otherwise we'll simply have to wait
for the next batch of mach-types updates.
next prev parent reply other threads:[~2011-11-24 8:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 6:08 [PATCH] ARM: Kota2 mach-type update fix Magnus Damm
2011-11-22 9:26 ` Paul Mundt
2011-11-22 11:41 ` Magnus Damm
2011-11-24 8:23 ` Paul Mundt [this message]
2011-11-24 9:28 ` Kuninori Morimoto
2011-11-24 10:35 ` Russell King - ARM Linux
2011-12-01 9:50 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111124082342.GD32112@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).