From: Richard Zhao <richard.zhao@linaro.org>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on
Date: Wed, 14 Dec 2011 14:05:04 +0000 [thread overview]
Message-ID: <20111214140500.GA1700@richard-laptop> (raw)
In-Reply-To: <20111214132622.GA1520@S2100-06.ap.freescale.net>
On Wed, Dec 14, 2011 at 09:26:24PM +0800, Shawn Guo wrote:
> Hi Dave,
>
> Sorry for that I did not look into previous post to point it out.
>
> On Wed, Dec 14, 2011 at 11:39:41AM +0000, Dave Martin wrote:
> > The i.MX6 Quad SoC will work without the l2x0 L2 cache controller
> > support built into the kernel, so this patch removes the dependency
> > on CACHE_L2X0 and selects MIGHT_HAVE_CACHE_L2X0 instead.
> >
> > This makes the l2x0 support optional, so that it can be turned off
> > when desired for debugging purposes etc.
> >
> > Thanks to Shawn Guo for this suggestion. [1]
> >
> > Signed-off-by: Dave Martin <dave.martin@linaro.org>
> >
> > [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/074602.html
> > ---
> > arch/arm/mach-imx/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
> > index 29a3d61..1fb93f2 100644
> > --- a/arch/arm/mach-imx/Kconfig
> > +++ b/arch/arm/mach-imx/Kconfig
> > @@ -609,13 +609,13 @@ comment "i.MX6 family:"
> > config SOC_IMX6Q
> > bool "i.MX6 Quad support"
> > select ARM_GIC
> > - select CACHE_L2X0
> > select CPU_V7
> > select HAVE_ARM_SCU
> > select HAVE_IMX_GPC
> > select HAVE_IMX_MMDC
> > select HAVE_IMX_SRC
> > select HAVE_SMP
> > + select MIGHT_HAVE_CACHE_L2X0
>
> The option SOC_IMX6Q is only available when ARCH_IMX_V6_V7 is selected.
> Since MIGHT_HAVE_CACHE_L2X0 has been selected by ARCH_IMX_V6_V7 in
> patch #1, this line seems redundant here.
Would it be better keep this one and remove patch #1 one? imx5 doesn't have
l2x0.
Thanks
Richard
>
> Regards,
> Shawn
>
> > select USE_OF
> >
> > help
> > --
> > 1.7.4.1
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
> >
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2011-12-14 14:05 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 11:39 [PATCH v4 REPOST 0/5] Refactor common Kconfigs for easier maintenance Dave Martin
2011-12-14 11:39 ` [PATCH v4 REPOST 1/5] ARM: l2x0/pl310: Refactor Kconfig to be more maintainable Dave Martin
2011-12-14 12:03 ` [PATCH v4 REPOST 1/5] ARM: l2x0/pl310: Refactor Kconfig to be Anton Vorontsov
2011-12-14 18:15 ` Tony Lindgren
2011-12-14 11:39 ` [PATCH v4 REPOST 2/5] ARM: SMP: Refactor Kconfig to be more maintainable Dave Martin
2011-12-14 18:16 ` [PATCH v4 REPOST 2/5] ARM: SMP: Refactor Kconfig to be more Tony Lindgren
2011-12-15 18:14 ` David Brown
2011-12-16 0:31 ` David Brown
2011-12-14 11:39 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 cache controller support Dave Martin
2011-12-14 18:14 ` [PATCH v4 REPOST 3/5] omap4: Unconditionally require l2x0 L2 Tony Lindgren
2011-12-14 18:30 ` Dave Martin
2011-12-14 18:39 ` Tony Lindgren
2011-12-14 21:01 ` Rob Herring
2011-12-14 21:48 ` Tony Lindgren
2011-12-14 11:39 ` [PATCH v4 REPOST 4/5] highbank: Unconditionally require l2x0 L2 cache controller support Dave Martin
2011-12-14 13:37 ` [PATCH v4 REPOST 4/5] highbank: Unconditionally require l2x0 Rob Herring
2011-12-14 13:55 ` [PATCH v4 REPOST 4/5] highbank: Unconditionally require l2x0 L2 Dave Martin
2011-12-14 11:39 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on l2x0 L2 cache support Dave Martin
2011-12-14 13:26 ` [PATCH v4 REPOST 5/5] imx6q: Remove unconditional dependency on Shawn Guo
2011-12-14 14:05 ` Richard Zhao [this message]
2011-12-14 15:01 ` Dave Martin
2011-12-15 1:02 ` Richard Zhao
2011-12-15 1:46 ` Shawn Guo
2011-12-15 1:54 ` Richard Zhao
2011-12-15 15:14 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111214140500.GA1700@richard-laptop \
--to=richard.zhao@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).