* [PATCH] ARM: mach-shmobile: Fix headsmp.S code to use CPUINIT
@ 2011-12-28 7:44 Magnus Damm
0 siblings, 0 replies; 2+ messages in thread
From: Magnus Damm @ 2011-12-28 7:44 UTC (permalink / raw)
To: linux-sh
From: Magnus Damm <damm@opensource.se>
Convert the low level SMP assembly code for SH-Mobile ARM
from using the INIT to the CPUINIT section. This unbreaks
onlining of CPUs using the CPU hotplug interface:
echo 1 > /sys/devices/system/cpu/cpu1/online
Without this fix the reset vector code used by CPU hotplug
will be freed as init section data and CPU cores cannot
be brought online.
Signed-off-by: Magnus Damm <damm@opensource.se>
---
arch/arm/mach-shmobile/headsmp.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- 0001/arch/arm/mach-shmobile/headsmp.S
+++ work/arch/arm/mach-shmobile/headsmp.S 2011-12-28 14:16:01.000000000 +0900
@@ -14,7 +14,7 @@
#include <linux/init.h>
#include <asm/memory.h>
- __INIT
+ __CPUINIT
/*
* Reset vector for secondary CPUs.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: mach-shmobile: Fix headsmp.S code to use CPUINIT
@ 2012-01-09 1:38 Paul Mundt
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2012-01-09 1:38 UTC (permalink / raw)
To: linux-sh
On Wed, Dec 28, 2011 at 04:44:06PM +0900, Magnus Damm wrote:
> Convert the low level SMP assembly code for SH-Mobile ARM
> from using the INIT to the CPUINIT section. This unbreaks
> onlining of CPUs using the CPU hotplug interface:
>
> echo 1 > /sys/devices/system/cpu/cpu1/online
>
> Without this fix the reset vector code used by CPU hotplug
> will be freed as init section data and CPU cores cannot
> be brought online.
On Wed, Dec 28, 2011 at 04:47:16PM +0900, Magnus Damm wrote:
> Add the function shmobile_platform_kill_cpu() to allow
> SoC specific code to tie in their CPU shutdown code.
On Wed, Dec 28, 2011 at 04:53:16PM +0900, Magnus Damm wrote:
> Add cache flushing code to the SH-Mobile specific CPU hotplug
> implementation. While at it, add a cpu mask to make sure the
> cache flushing code is finished in platform_cpu_die() before
> letting the SoC-specific code in shmobile_platform_cpu_kill()
> proceed with turning off power.
>
> Without this code CPU hotplug offline fails when cache is
> enabled on Cortex-A9 based SoCs.
All applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-09 1:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-09 1:38 [PATCH] ARM: mach-shmobile: Fix headsmp.S code to use CPUINIT Paul Mundt
-- strict thread matches above, loose matches on Subject: below --
2011-12-28 7:44 Magnus Damm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).