From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dmaengine: shdma: modify the DMAC Address Error registration
Date: Tue, 10 Jan 2012 07:18:06 +0000 [thread overview]
Message-ID: <20120110071805.GA24305@linux-sh.org> (raw)
In-Reply-To: <4F0BDCD5.9020603@renesas.com>
On Tue, Jan 10, 2012 at 03:38:13PM +0900, Shimoda, Yoshihiro wrote:
> The USB-DMAC/SUDMAC don't have the interrupt of DMAC Address Error.
> So, only when the resource has a name and it is "error_irq", the driver
> calls request_irq() for DMAC Address Error.
>
> This patch is also useful for the generic DMAC which doesn't have
> DMAC Address Error. So, we can get rid of the "CPU_SH4 || ARCH_SHMOBILE"
> ifdefs.
> This patch also changes the IRQF_DISABLED to 0.
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
> about v3:
> - changes the IRQF_DISABLED to 0.
>
> drivers/dma/shdma.c | 78 ++++++++++++++++++++++++++-------------------------
> 1 files changed, 40 insertions(+), 38 deletions(-)
>
The updated patches look fine to me, thanks for fixing them up. I'll let
Vinod pick them up.
Acked-by: Paul Mundt <lethal@linux-sh.org>
next prev parent reply other threads:[~2012-01-10 7:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 6:38 [PATCH v3 1/3] dmaengine: shdma: modify the DMAC Address Error Shimoda, Yoshihiro
2012-01-10 7:18 ` Paul Mundt [this message]
2012-01-10 9:48 ` Guennadi Liakhovetski
2012-01-11 0:43 ` Shimoda, Yoshihiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120110071805.GA24305@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).