[PATCH] arm: mach-shmobile: add a resource name for shdma

[PATCH] arm: mach-shmobile: add a resource name for shdma

[Shimoda, Yoshihiro]

Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
 This patch depends on the following patch:
   - dmaengine: shdma: modify the DMAC Address Error registration

 arch/arm/mach-shmobile/setup-sh7372.c |    6 +++---
 arch/arm/mach-shmobile/setup-sh73a0.c |    2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-shmobile/setup-sh7372.c b/arch/arm/mach-shmobile/setup-sh7372.c
index 2380389..dad4d09 100644
--- a/arch/arm/mach-shmobile/setup-sh7372.c
+++ b/arch/arm/mach-shmobile/setup-sh7372.c
@@ -504,7 +504,7 @@ static struct resource sh7372_dmae0_resources[] = {
 		.flags	= IORESOURCE_MEM,
 	},
 	{
-		/* DMA error IRQ */
+		.name	= "error_irq",
 		.start	= evt2irq(0x20c0),
 		.end	= evt2irq(0x20c0),
 		.flags	= IORESOURCE_IRQ,
@@ -532,7 +532,7 @@ static struct resource sh7372_dmae1_resources[] = {
 		.flags	= IORESOURCE_MEM,
 	},
 	{
-		/* DMA error IRQ */
+		.name	= "error_irq",
 		.start	= evt2irq(0x21c0),
 		.end	= evt2irq(0x21c0),
 		.flags	= IORESOURCE_IRQ,
@@ -560,7 +560,7 @@ static struct resource sh7372_dmae2_resources[] = {
 		.flags	= IORESOURCE_MEM,
 	},
 	{
-		/* DMA error IRQ */
+		.name	= "error_irq",
 		.start	= evt2irq(0x22c0),
 		.end	= evt2irq(0x22c0),
 		.flags	= IORESOURCE_IRQ,
diff --git a/arch/arm/mach-shmobile/setup-sh73a0.c b/arch/arm/mach-shmobile/setup-sh73a0.c
index e46821c..20e71e5 100644
--- a/arch/arm/mach-shmobile/setup-sh73a0.c
+++ b/arch/arm/mach-shmobile/setup-sh73a0.c
@@ -607,7 +607,7 @@ static struct resource sh73a0_dmae_resources[] = {
 		.flags  = IORESOURCE_MEM,
 	},
 	{
-		/* DMA error IRQ */
+		.name	= "error_irq",
 		.start  = gic_spi(129),
 		.end    = gic_spi(129),
 		.flags  = IORESOURCE_IRQ,
-- 
1.7.1

Re: [PATCH] arm: mach-shmobile: add a resource name for shdma

[Paul Mundt]

On Tue, Jan 10, 2012 at 02:21:31PM +0900, Shimoda, Yoshihiro wrote:
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  This patch depends on the following patch:
>    - dmaengine: shdma: modify the DMAC Address Error registration
> 
What exactly does it depend on? If it's just wiring up the string, we can
merge that at any time, and the earlier the better. Setting the string
doesn't introduce any different behaviour in the driver as it is now
without the change in registration.

Re: [PATCH] arm: mach-shmobile: add a resource name for shdma

[Shimoda, Yoshihiro]

2012/01/10 16:43, Paul Mundt wrote:
> On Tue, Jan 10, 2012 at 02:21:31PM +0900, Shimoda, Yoshihiro wrote:
>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>> ---
>>  This patch depends on the following patch:
>>    - dmaengine: shdma: modify the DMAC Address Error registration
>>
> What exactly does it depend on? If it's just wiring up the string, we can
> merge that at any time, and the earlier the better. Setting the string
> doesn't introduce any different behaviour in the driver as it is now
> without the change in registration.
> 

I'm sorry for my wrong comment. Your point is correct.
This patch doesn't depend on the shdma's patch.

Should I submit the patch which removed the comment again?

Best regards,
Yoshihiro Shimoda

-- 
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
EC No.

Re: [PATCH] arm: mach-shmobile: add a resource name for shdma

[Paul Mundt]

On Tue, Jan 10, 2012 at 05:22:49PM +0900, Shimoda, Yoshihiro wrote:
> 2012/01/10 16:43, Paul Mundt wrote:
> > On Tue, Jan 10, 2012 at 02:21:31PM +0900, Shimoda, Yoshihiro wrote:
> >> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> >> ---
> >>  This patch depends on the following patch:
> >>    - dmaengine: shdma: modify the DMAC Address Error registration
> >>
> > What exactly does it depend on? If it's just wiring up the string, we can
> > merge that at any time, and the earlier the better. Setting the string
> > doesn't introduce any different behaviour in the driver as it is now
> > without the change in registration.
> > 
> 
> I'm sorry for my wrong comment. Your point is correct.
> This patch doesn't depend on the shdma's patch.
> 
> Should I submit the patch which removed the comment again?
> 
No, it's fine, just wanted to make sure there wasn't something sinister
going on that I wasn't aware of with regards to the driver model. I'll
apply them to sh/rmobile-latest respectively.

Re: [PATCH] arm: mach-shmobile: add a resource name for shdma

[Shimoda, Yoshihiro]

2012/01/10 17:25, Paul Mundt wrote:
> On Tue, Jan 10, 2012 at 05:22:49PM +0900, Shimoda, Yoshihiro wrote:
>> 2012/01/10 16:43, Paul Mundt wrote:
>>> On Tue, Jan 10, 2012 at 02:21:31PM +0900, Shimoda, Yoshihiro wrote:
>>>> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
>>>> ---
>>>>  This patch depends on the following patch:
>>>>    - dmaengine: shdma: modify the DMAC Address Error registration
>>>>
>>> What exactly does it depend on? If it's just wiring up the string, we can
>>> merge that at any time, and the earlier the better. Setting the string
>>> doesn't introduce any different behaviour in the driver as it is now
>>> without the change in registration.
>>>
>>
>> I'm sorry for my wrong comment. Your point is correct.
>> This patch doesn't depend on the shdma's patch.
>>
>> Should I submit the patch which removed the comment again?
>>
> No, it's fine, just wanted to make sure there wasn't something sinister
> going on that I wasn't aware of with regards to the driver model. I'll
> apply them to sh/rmobile-latest respectively.
> 

Thank you very much. I understood it.

Best regards,
Yoshihiro Shimoda