Re: [PATCH v4 1/6] dmaengine: shdma: add IRQ resource name definition macros

[Paul Mundt <lethal@linux-sh.org>]

On Wed, Jan 11, 2012 at 04:27:35PM +0900, Shimoda, Yoshihiro wrote:
> The SH DMAC has an ERROR IRQ and channel IRQs. So, the defination
> macros are used as the resource name, and the resource name will be
> used to detect each IRQ by the driver.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> ---
>  about v4:
>   - add defination macros for IRQ resource first.
> 
>  include/linux/sh_dma.h |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/sh_dma.h b/include/linux/sh_dma.h
> index cb2dd11..a6c82cc 100644
> --- a/include/linux/sh_dma.h
> +++ b/include/linux/sh_dma.h
> @@ -13,6 +13,10 @@
>  #include <linux/list.h>
>  #include <linux/dmaengine.h>
> 
> +/* resource name of IORESOURCE_IRQ */
> +#define SH_DMA_IRQ_ERROR	"error"
> +#define SH_DMA_IRQ_CHANNEL	"channel"
> +
Why? This is just pointless churn, there's nothing wrong with using the
strings open-coded like the vast majority of other drivers/platforms do
without issue. If you can't spell it properly, too bad.