linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: mach-shmobile: sh73a0 PINT IRQ base fix
@ 2012-01-17 11:05 Magnus Damm
  2012-01-18  0:22 ` Paul Mundt
  0 siblings, 1 reply; 2+ messages in thread
From: Magnus Damm @ 2012-01-17 11:05 UTC (permalink / raw)
  To: linux-sh

From: Magnus Damm <damm@opensource.se>

Bump up the sh73a0 PINT IRQ base from 768 to 800 to avoid
collision with INTCS vectors for IRQ16->IRQ32 at 0x3xxx.

Without this fix the sh73a0 IRQ pin handling code collides
with the PINT code which results in hangs on Kota2 during boot.

Signed-off-by: Magnus Damm <damm@opensource.se>
---

 arch/arm/mach-shmobile/include/mach/sh73a0.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

--- 0001/arch/arm/mach-shmobile/include/mach/sh73a0.h
+++ work/arch/arm/mach-shmobile/include/mach/sh73a0.h	2012-01-17 19:34:48.000000000 +0900
@@ -515,8 +515,8 @@ enum {
 	SHDMA_SLAVE_MMCIF_RX,
 };
 
-/* PINT interrupts are located at Linux IRQ 768 and up */
-#define SH73A0_PINT0_IRQ(irq) ((irq) + 768)
-#define SH73A0_PINT1_IRQ(irq) ((irq) + 800)
+/* PINT interrupts are located at Linux IRQ 800 and up */
+#define SH73A0_PINT0_IRQ(irq) ((irq) + 800)
+#define SH73A0_PINT1_IRQ(irq) ((irq) + 832)
 
 #endif /* __ASM_SH73A0_H__ */

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ARM: mach-shmobile: sh73a0 PINT IRQ base fix
  2012-01-17 11:05 [PATCH] ARM: mach-shmobile: sh73a0 PINT IRQ base fix Magnus Damm
@ 2012-01-18  0:22 ` Paul Mundt
  0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2012-01-18  0:22 UTC (permalink / raw)
  To: linux-sh

On Tue, Jan 17, 2012 at 08:05:40PM +0900, Magnus Damm wrote:
> Bump up the sh73a0 PINT IRQ base from 768 to 800 to avoid
> collision with INTCS vectors for IRQ16->IRQ32 at 0x3xxx.
> 
> Without this fix the sh73a0 IRQ pin handling code collides
> with the PINT code which results in hangs on Kota2 during boot.

On Tue, Jan 17, 2012 at 08:10:49PM +0900, Magnus Damm wrote:
> Fix the sh73a0 external IRQ pin code to properly support
> CONFIG_SPARSE_IRQ=y by allocating IRQ descriptors for the
> cascaded IRQs associated with external IRQ pins.
> 
> Without this fix it is impossible to request IRQ0->IRQ31
> on the Kota2 board when sparse IRQs are enabled. 

On Tue, Jan 17, 2012 at 08:14:07PM +0900, Magnus Damm wrote:
> Now when GPIO IRQs are supported on sh73a0 modify the Kota2
> board code to switch from the polled "gpio-keys-polled" driver
> to the IRQ driven "gpio-keys" driver.

All applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-01-18  0:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-17 11:05 [PATCH] ARM: mach-shmobile: sh73a0 PINT IRQ base fix Magnus Damm
2012-01-18  0:22 ` Paul Mundt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).