From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Guan Xuetao <gxt@mprc.pku.edu.cn>,
Ralf Baechle <ralf@linux-mips.org>,
Paul Mundt <lethal@linux-sh.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Mike Frysinger <vapier@gentoo.org>,
Haavard Skinnemoen <hskinnemoen@gmail.com>,
Hans-Christian Egtvedt <egtvedt@samfundet.no>,
Grant Likely <grant.likely@secretlab.ca>,
linux-arch@vger.kernel.org, linux-mips@linux-mips.org,
uclinux-dist-devel@blackfin.uclinux.org,
linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h
Date: Mon, 06 Feb 2012 11:37:20 +0000 [thread overview]
Message-ID: <20120206113720.GG3070@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120204174115.GX889@n2100.arm.linux.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1096 bytes --]
On Sat, Feb 04, 2012 at 05:41:15PM +0000, Russell King - ARM Linux wrote:
> What's platform specific about asm/gpio.h is the number of GPIOs in
> the system, and whether it wants to intercept the gpio_xxx() functions
> to provide fast access to on-chip GPIOs.
Plus the fact that it might be a completely non-standard API, and might
totally override the gpiolib implementation.
> What I'd suggest is moving asm-generic/gpio.h to linux/gpiolib.h, and
> making asm-generic/gpio.h include that as a patch until stuff is fixed
> for its new location. That should result in a proper asm-generic/gpio.h
> being:
> Alternatively, instead of linux/gpiolib.h, put it in linux/gpio.h instead,
> but that gets more icky because of the mess of asm/gpio.h includes (which
> I've been banging on for years about in ARM patches and they're _still_
> coming.)
Yeah, though it is a bit neater if it's all in gpio.h and everyone is
using gpiolib. Perhaps something like the warnings I added on inclusion
of asm/gpio.h without linux/gpio.h would help, though I certainly
wouldn't expect it to solve anything.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-02-06 11:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-25 7:33 [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h Mark Brown
2011-10-25 8:33 ` Grant Likely
2011-10-25 8:39 ` Mark Brown
2011-10-25 23:44 ` Mike Frysinger
2011-10-26 7:33 ` Mark Brown
2012-02-03 23:16 ` Grant Likely
2011-10-27 13:01 ` [PATCH] asm-generic/gpio.h: merge basic gpiolib wrappers Mike Frysinger
2011-10-27 22:52 ` [PATCH v2] " Mike Frysinger
2011-11-03 3:45 ` [PATCH v3] " Mike Frysinger
2012-02-04 15:54 ` [PATCH] gpiolib/arches: Centralise bolierplate asm/gpio.h Mark Brown
2012-02-04 17:06 ` Sam Ravnborg
2012-02-04 17:21 ` Mark Brown
2012-02-04 17:41 ` Russell King - ARM Linux
2012-02-06 11:37 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120206113720.GG3070@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=egtvedt@samfundet.no \
--cc=geert@linux-m68k.org \
--cc=grant.likely@secretlab.ca \
--cc=gxt@mprc.pku.edu.cn \
--cc=hskinnemoen@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ralf@linux-mips.org \
--cc=sam@ravnborg.org \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).