[PATCH 1/2 v3] usb: renesas_usbhs: (cosmetic) simplify list operations

[PATCH 1/2 v3] usb: renesas_usbhs: (cosmetic) simplify list operations

[Guennadi Liakhovetski]

list.h already provide helpers to find the first entry and to move list
nodes to the tail of another list. This patch simply uses those helpers,
no functional changes.

Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---

v3: added a description, as suggested by Felipe, thanks

 drivers/usb/renesas_usbhs/fifo.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c
index 72339bd..5d543e3 100644
--- a/drivers/usb/renesas_usbhs/fifo.c
+++ b/drivers/usb/renesas_usbhs/fifo.c
@@ -75,8 +75,7 @@ void usbhs_pkt_push(struct usbhs_pipe *pipe, struct usbhs_pkt *pkt,
 		pipe->handler = &usbhsf_null_handler;
 	}
 
-	list_del_init(&pkt->node);
-	list_add_tail(&pkt->node, &pipe->list);
+	list_move_tail(&pkt->node, &pipe->list);
 
 	/*
 	 * each pkt must hold own handler.
@@ -106,7 +105,7 @@ static struct usbhs_pkt *__usbhsf_pkt_get(struct usbhs_pipe *pipe)
 	if (list_empty(&pipe->list))
 		return NULL;
 
-	return list_entry(pipe->list.next, struct usbhs_pkt, node);
+	return list_first_entry(&pipe->list, struct usbhs_pkt, node);
 }
 
 struct usbhs_pkt *usbhs_pkt_pop(struct usbhs_pipe *pipe, struct usbhs_pkt *pkt)
-- 
1.7.2.5

Re: [PATCH 1/2 v3] usb: renesas_usbhs: (cosmetic) simplify list operations

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 350 bytes --]

On Tue, Feb 14, 2012 at 11:37:17AM +0100, Guennadi Liakhovetski wrote:
> list.h already provide helpers to find the first entry and to move list
> nodes to the tail of another list. This patch simply uses those helpers,
> no functional changes.
> 
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>

applied, thanks

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]