From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Thu, 15 Mar 2012 09:39:21 +0000 Subject: Re: [Replacement][PATCH 2/6] PM / Domains: Fix hibernation restore of devices, v2 Message-Id: <20120315093921.GA15294@verge.net.au> List-Id: References: <201203130123.16268.rjw@sisk.pl> <201203130124.59376.rjw@sisk.pl> <201203132232.42915.rjw@sisk.pl> In-Reply-To: <201203132232.42915.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Rafael J. Wysocki" Cc: Linux-sh list , Linux PM list , Paul Mundt , Magnus Damm , LKML , Cao Minh Hiep On Tue, Mar 13, 2012 at 10:32:42PM +0100, Rafael J. Wysocki wrote: > On Tuesday, March 13, 2012, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > During resume from hibernation pm_genpd_restore_noirq() has to > > deal with software state left by pm_genpd_suspend_noirq() and > > unknown hardware state (the boot kernel may leave all PM domains and > > devices in arbitrary states). For this reason, make it attempt to > > power cycle each domain when before resuming its first device to > > possibly get rid of any unwanted hardware state that may interfere > > with genpd_start_dev() later on. > > > > Signed-off-by: Rafael J. Wysocki > > I realized that this wasn't a good idea because of patch [3/6] (we > can't power cycle domains containing "always on" devices), so I > decided to only fix the really broken things in pm_genpd_restore_noirq(). > > Of course, patch [3/6] also needs to be updated on top of the below to > avoid starting "always on" devices in pm_genpd_restore_noirq() (it has > to assume that they will be "always on" in the boot kernel too, but that > seems to be a reasonable expectation). > > Please note that those changes only affect resume from hibernation, so > they don't invalidate the testing that has already been carried out. Hi Rafael, sorry for such a naeive question, but if I was to test hibernate on the Mackerel how would I achieve resume? Is there a button I should press?