[PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730

linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730
@ 2012-03-16  2:31 Nobuhiro Iwamatsu
  2012-03-16  4:11 ` Simon Horman
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Nobuhiro Iwamatsu @ 2012-03-16  2:31 UTC (permalink / raw)
  To: linux-sh

CHCR of SH7723 and SH7730 is constitution same as SH7724.

Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
---
 arch/sh/include/cpu-sh4/cpu/dma-register.h |   10 +++-------
 1 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/arch/sh/include/cpu-sh4/cpu/dma-register.h b/arch/sh/include/cpu-sh4/cpu/dma-register.h
index 18fa80a..1af4a95 100644
--- a/arch/sh/include/cpu-sh4/cpu/dma-register.h
+++ b/arch/sh/include/cpu-sh4/cpu/dma-register.h
@@ -16,14 +16,15 @@
 
 #define DMAOR_INIT	DMAOR_DME
 
-#if defined(CONFIG_CPU_SUBTYPE_SH7343) || \
-	defined(CONFIG_CPU_SUBTYPE_SH7730)
+#if defined(CONFIG_CPU_SUBTYPE_SH7343)
 #define CHCR_TS_LOW_MASK	0x00000018
 #define CHCR_TS_LOW_SHIFT	3
 #define CHCR_TS_HIGH_MASK	0
 #define CHCR_TS_HIGH_SHIFT	0
 #elif defined(CONFIG_CPU_SUBTYPE_SH7722) || \
+	defined(CONFIG_CPU_SUBTYPE_SH7723) || \
 	defined(CONFIG_CPU_SUBTYPE_SH7724) || \
+	defined(CONFIG_CPU_SUBTYPE_SH7730) || \
 	defined(CONFIG_CPU_SUBTYPE_SH7786)
 #define CHCR_TS_LOW_MASK	0x00000018
 #define CHCR_TS_LOW_SHIFT	3
@@ -35,11 +36,6 @@
 #define CHCR_TS_LOW_SHIFT	3
 #define CHCR_TS_HIGH_MASK	0
 #define CHCR_TS_HIGH_SHIFT	0
-#elif defined(CONFIG_CPU_SUBTYPE_SH7723)
-#define CHCR_TS_LOW_MASK	0x00000018
-#define CHCR_TS_LOW_SHIFT	3
-#define CHCR_TS_HIGH_MASK	0
-#define CHCR_TS_HIGH_SHIFT	0
 #elif defined(CONFIG_CPU_SUBTYPE_SH7757)
 #define CHCR_TS_LOW_MASK	0x00000018
 #define CHCR_TS_LOW_SHIFT	3
-- 
1.7.9.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730
  2012-03-16  2:31 [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730 Nobuhiro Iwamatsu
@ 2012-03-16  4:11 ` Simon Horman
  2012-03-19  0:54 ` Nobuhiro Iwamatsu
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2012-03-16  4:11 UTC (permalink / raw)
  To: linux-sh

Hi Iwamatsu-san,

On Fri, Mar 16, 2012 at 11:31:25AM +0900, Nobuhiro Iwamatsu wrote:
> CHCR of SH7723 and SH7730 is constitution same as SH7724.

Can I confirm that it is intentional that this patch changes the
CHCR_TS_HIGH_MASK and CHCR_TS_HIGH_SHIFT values for sh7723 and
sh7730?

> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
>  arch/sh/include/cpu-sh4/cpu/dma-register.h |   10 +++-------
>  1 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/sh/include/cpu-sh4/cpu/dma-register.h b/arch/sh/include/cpu-sh4/cpu/dma-register.h
> index 18fa80a..1af4a95 100644
> --- a/arch/sh/include/cpu-sh4/cpu/dma-register.h
> +++ b/arch/sh/include/cpu-sh4/cpu/dma-register.h
> @@ -16,14 +16,15 @@
>  
>  #define DMAOR_INIT	DMAOR_DME
>  
> -#if defined(CONFIG_CPU_SUBTYPE_SH7343) || \
> -	defined(CONFIG_CPU_SUBTYPE_SH7730)
> +#if defined(CONFIG_CPU_SUBTYPE_SH7343)
>  #define CHCR_TS_LOW_MASK	0x00000018
>  #define CHCR_TS_LOW_SHIFT	3
>  #define CHCR_TS_HIGH_MASK	0
>  #define CHCR_TS_HIGH_SHIFT	0
>  #elif defined(CONFIG_CPU_SUBTYPE_SH7722) || \
> +	defined(CONFIG_CPU_SUBTYPE_SH7723) || \
>  	defined(CONFIG_CPU_SUBTYPE_SH7724) || \
> +	defined(CONFIG_CPU_SUBTYPE_SH7730) || \
>  	defined(CONFIG_CPU_SUBTYPE_SH7786)
>  #define CHCR_TS_LOW_MASK	0x00000018
>  #define CHCR_TS_LOW_SHIFT	3
> @@ -35,11 +36,6 @@
>  #define CHCR_TS_LOW_SHIFT	3
>  #define CHCR_TS_HIGH_MASK	0
>  #define CHCR_TS_HIGH_SHIFT	0
> -#elif defined(CONFIG_CPU_SUBTYPE_SH7723)
> -#define CHCR_TS_LOW_MASK	0x00000018
> -#define CHCR_TS_LOW_SHIFT	3
> -#define CHCR_TS_HIGH_MASK	0
> -#define CHCR_TS_HIGH_SHIFT	0
>  #elif defined(CONFIG_CPU_SUBTYPE_SH7757)
>  #define CHCR_TS_LOW_MASK	0x00000018
>  #define CHCR_TS_LOW_SHIFT	3
> -- 
> 1.7.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730
  2012-03-16  2:31 [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730 Nobuhiro Iwamatsu
  2012-03-16  4:11 ` Simon Horman
@ 2012-03-19  0:54 ` Nobuhiro Iwamatsu
  2012-03-19  0:56 ` Simon Horman
  2012-03-28  5:32 ` Paul Mundt
  3 siblings, 0 replies; 5+ messages in thread
From: Nobuhiro Iwamatsu @ 2012-03-19  0:54 UTC (permalink / raw)
  To: linux-sh

Hi,

Simon Horman さんは書きました:
> Hi Iwamatsu-san,
> 
> On Fri, Mar 16, 2012 at 11:31:25AM +0900, Nobuhiro Iwamatsu wrote:
>> CHCR of SH7723 and SH7730 is constitution same as SH7724.
> 
> Can I confirm that it is intentional that this patch changes the
> CHCR_TS_HIGH_MASK and CHCR_TS_HIGH_SHIFT values for sh7723 and
> sh7730?

Yes, you can check only sh7730.
I think that sh7724 cannot be checked.
Because the manual of sh7724 is not exhibited.

I checked this change with manual of japanese and english.

Best regards,
   Nobuhiro

> 
>> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
>> ---
>>  arch/sh/include/cpu-sh4/cpu/dma-register.h |   10 +++-------
>>  1 files changed, 3 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/sh/include/cpu-sh4/cpu/dma-register.h b/arch/sh/include/cpu-sh4/cpu/dma-register.h
>> index 18fa80a..1af4a95 100644
>> --- a/arch/sh/include/cpu-sh4/cpu/dma-register.h
>> +++ b/arch/sh/include/cpu-sh4/cpu/dma-register.h
>> @@ -16,14 +16,15 @@
>>  
>>  #define DMAOR_INIT	DMAOR_DME
>>  
>> -#if defined(CONFIG_CPU_SUBTYPE_SH7343) || \
>> -	defined(CONFIG_CPU_SUBTYPE_SH7730)
>> +#if defined(CONFIG_CPU_SUBTYPE_SH7343)
>>  #define CHCR_TS_LOW_MASK	0x00000018
>>  #define CHCR_TS_LOW_SHIFT	3
>>  #define CHCR_TS_HIGH_MASK	0
>>  #define CHCR_TS_HIGH_SHIFT	0
>>  #elif defined(CONFIG_CPU_SUBTYPE_SH7722) || \
>> +	defined(CONFIG_CPU_SUBTYPE_SH7723) || \
>>  	defined(CONFIG_CPU_SUBTYPE_SH7724) || \
>> +	defined(CONFIG_CPU_SUBTYPE_SH7730) || \
>>  	defined(CONFIG_CPU_SUBTYPE_SH7786)
>>  #define CHCR_TS_LOW_MASK	0x00000018
>>  #define CHCR_TS_LOW_SHIFT	3
>> @@ -35,11 +36,6 @@
>>  #define CHCR_TS_LOW_SHIFT	3
>>  #define CHCR_TS_HIGH_MASK	0
>>  #define CHCR_TS_HIGH_SHIFT	0
>> -#elif defined(CONFIG_CPU_SUBTYPE_SH7723)
>> -#define CHCR_TS_LOW_MASK	0x00000018
>> -#define CHCR_TS_LOW_SHIFT	3
>> -#define CHCR_TS_HIGH_MASK	0
>> -#define CHCR_TS_HIGH_SHIFT	0
>>  #elif defined(CONFIG_CPU_SUBTYPE_SH7757)
>>  #define CHCR_TS_LOW_MASK	0x00000018
>>  #define CHCR_TS_LOW_SHIFT	3
>> -- 
>> 1.7.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
> 


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730
  2012-03-16  2:31 [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730 Nobuhiro Iwamatsu
  2012-03-16  4:11 ` Simon Horman
  2012-03-19  0:54 ` Nobuhiro Iwamatsu
@ 2012-03-19  0:56 ` Simon Horman
  2012-03-28  5:32 ` Paul Mundt
  3 siblings, 0 replies; 5+ messages in thread
From: Simon Horman @ 2012-03-19  0:56 UTC (permalink / raw)
  To: linux-sh

On Mon, Mar 19, 2012 at 09:54:12AM +0900, Nobuhiro Iwamatsu wrote:
> Hi,
> 
> Simon Horman さんは書きました:
> >Hi Iwamatsu-san,
> >
> >On Fri, Mar 16, 2012 at 11:31:25AM +0900, Nobuhiro Iwamatsu wrote:
> >>CHCR of SH7723 and SH7730 is constitution same as SH7724.
> >
> >Can I confirm that it is intentional that this patch changes the
> >CHCR_TS_HIGH_MASK and CHCR_TS_HIGH_SHIFT values for sh7723 and
> >sh7730?
> 
> Yes, you can check only sh7730.
> I think that sh7724 cannot be checked.
> Because the manual of sh7724 is not exhibited.
> 
> I checked this change with manual of japanese and english.

Hi Nobuhiro,

thanks for confirming the intention of the change.

Reviewed-by: Simon Horman <horms@verge.net.au>

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730
  2012-03-16  2:31 [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730 Nobuhiro Iwamatsu
                   ` (2 preceding siblings ...)
  2012-03-19  0:56 ` Simon Horman
@ 2012-03-28  5:32 ` Paul Mundt
  3 siblings, 0 replies; 5+ messages in thread
From: Paul Mundt @ 2012-03-28  5:32 UTC (permalink / raw)
  To: linux-sh

On Fri, Mar 16, 2012 at 11:31:25AM +0900, Nobuhiro Iwamatsu wrote:
> CHCR of SH7723 and SH7730 is constitution same as SH7724.

On Fri, Mar 16, 2012 at 11:31:26AM +0900, Nobuhiro Iwamatsu wrote:
> CHCR of SH7763, SH7764, SH7780 and SH7785 is constitution same as SH7757.

Both applied, thanks.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2012-03-28  5:32 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-03-16  2:31 [PATCH 1/2] sh: dma: Collect up CHCR of SH7723 and SH7730 Nobuhiro Iwamatsu
2012-03-16  4:11 ` Simon Horman
2012-03-19  0:54 ` Nobuhiro Iwamatsu
2012-03-19  0:56 ` Simon Horman
2012-03-28  5:32 ` Paul Mundt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).