SUPERH platform development
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support
Date: Wed, 04 Apr 2012 05:39:51 +0000	[thread overview]
Message-ID: <20120404053950.GA8071@verge.net.au> (raw)
In-Reply-To: <87sjgm9ais.wl%kuninori.morimoto.gx@renesas.com>

Hi Morimoto-san,

On Sun, Apr 01, 2012 at 06:40:14PM -0700, Kuninori Morimoto wrote:
> We needs un-manualed address to use DMA
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
>  arch/arm/mach-shmobile/board-mackerel.c |    8 ++++++--
>  1 files changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 13ba0ac..ff73e5a 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -922,6 +922,8 @@ fsi_set_rate_end:
>  static struct sh_fsi_platform_info fsi_info = {
>  	.port_a = {
>  		.flags = SH_FSI_BRS_INV,
> +		.tx_id = SHDMA_SLAVE_FSIA_TX,
> +		.rx_id = SHDMA_SLAVE_FSIA_RX,
>  	},
>  	.port_b = {
>  		.flags = SH_FSI_BRS_INV	|

Which tree does this apply to or is there a dependency?
I'm having trouble with the above hunk both on v3.3 and
the soc branch of Rafael's renesas tree.

> @@ -934,9 +936,11 @@ static struct sh_fsi_platform_info fsi_info = {
>  
>  static struct resource fsi_resources[] = {
>  	[0] = {
> +		/* we need 0xFE1F0000 to access DMA
> +		 * instead of 0xFE3C0000 */
>  		.name	= "FSI",
> -		.start	= 0xFE3C0000,
> -		.end	= 0xFE3C0400 - 1,
> +		.start  = 0xFE1F0000,
> +		.end    = 0xFE1F0400 - 1,
>  		.flags	= IORESOURCE_MEM,
>  	},
>  	[1] = {
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

  parent reply	other threads:[~2012-04-04  5:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02  1:40 [PATCH resend 2/2] ARM: mach-shmobile: mackerel: Add FSI DMAEngine support Kuninori Morimoto
2012-04-02  5:06 ` Simon Horman
2012-04-02  5:31 ` Kuninori Morimoto
2012-04-04  5:39 ` Simon Horman [this message]
2012-04-04  5:49 ` Kuninori Morimoto
2012-04-04  6:06 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120404053950.GA8071@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox