linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] serial: sh-sci: modify sci_break_ctl()
Date: Fri, 06 Apr 2012 05:11:16 +0000	[thread overview]
Message-ID: <20120406051116.GF27120@verge.net.au> (raw)
In-Reply-To: <4F7E3FE2.4050902@renesas.com>

On Fri, Apr 06, 2012 at 12:50:00PM +0900, Shimoda, Yoshihiro wrote:
> 2012/04/06 11:44, Simon Horman wrote:
> > On Fri, Apr 06, 2012 at 11:13:24AM +0900, Shimoda, Yoshihiro wrote:
> >>
> >> Thank you for the check.
> >> setup-xxxx.c which have "PORT_SCIF" can be tested:
> >>  - SH7724, SH7785, R8A7779, etc.
> > 
> > Thanks, I will try and test on ecovec which I believe has SH7724.
> 
> Yes, ecovec has SH7724.
> 
> > Do you have any information on how I should test the code,
> > other than booting it
> 
> If userland calls ioctl with TIOCSBRK/TIOCCBRK, the sci_break_ctl
> is called. After TIOCSBRK we cannot send data from SCIF.
> After TIOCCBRK, we can send data from SCIF.

Thanks, that make a lot of sense.

Unfortunately the ecovec doesn't exercise the new code
as the regtype of its scif is SCIx_SH4_SCIF_NO_SCSPTR_REGTYPE
but your code only operates on SCIx_SH4_SCIF_REGTYPE.

  parent reply	other threads:[~2012-04-06  5:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-06  0:59 [PATCH v2] serial: sh-sci: modify sci_break_ctl() Shimoda, Yoshihiro
2012-04-06  1:57 ` Simon Horman
2012-04-06  2:13 ` Shimoda, Yoshihiro
2012-04-06  2:44 ` Simon Horman
2012-04-06  3:50 ` Shimoda, Yoshihiro
2012-04-06  5:11 ` Simon Horman [this message]
2012-04-06  5:39 ` Shimoda, Yoshihiro
2012-04-06 11:13 ` Simon Horman
2012-04-09  7:59 ` Paul Mundt
2012-04-11  4:28 ` Paul Mundt
2012-04-11  9:36 ` Shimoda, Yoshihiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120406051116.GF27120@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).