From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH/RFC] sh: ecovec: switch MMC power control to regulator
Date: Fri, 20 Apr 2012 17:07:44 +0000 [thread overview]
Message-ID: <20120420170744.GC3080@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1204201850180.3974@axis700.grange>
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
On Fri, Apr 20, 2012 at 06:59:41PM +0200, Guennadi Liakhovetski wrote:
> +static struct gpio_regulator_state mmcif_power_states[] = {
> + { .value = 3300000, .gpios = 0 },
> +};
It doesn't make much odds but if you've only got one voltage the fixed
voltage regulator is a little more idiomatic here (there's some overlap
as they've been evolving separately. No harm in gpio-regulator though.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-20 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 16:59 [PATCH 0/5] mmc: sh_mmcif: add regulator support Guennadi Liakhovetski
2012-04-20 16:59 ` [PATCH/RFC] sh: ecovec: switch MMC power control to regulator Guennadi Liakhovetski
2012-04-20 17:07 ` Mark Brown [this message]
2012-04-20 19:56 ` [PATCH/RFC 5/5] " Guennadi Liakhovetski
2012-04-24 11:46 ` [PATCH/RFC] " Guennadi Liakhovetski
2012-04-24 12:14 ` Mark Brown
2012-04-20 16:59 ` [PATCH 1/5] mmc: sh_mmcif: remove redundant .down_pwr() callback Guennadi Liakhovetski
2012-04-20 16:59 ` [PATCH 2/5] sh: ecovec: remove unused .down_pwr() MMCIF callback Guennadi Liakhovetski
2012-04-20 16:59 ` [PATCH 3/5] mmc: sh_mmcif: remove unused .down_pwr() callback Guennadi Liakhovetski
2012-04-20 16:59 ` [PATCH 4/5] mmc: sh_mmcif: add regulator support Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120420170744.GC3080@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=lrg@ti.com \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).