Re: [RFC/PATCH] sh: Remove cast of atomic_t in ATOMIC_INIT macro

[Paul Mundt <lethal@linux-sh.org>]

On Mon, Apr 23, 2012 at 11:48:32AM +0900, Nobuhiro Iwamatsu wrote:
> Hi,
> 
> By the update of the trace system (enable CONFIG_TRACING), trace build is not made in SH.
> This is macro of trace, and ATOMIC_INIT is used, but becomes the build error with an initialization code.
> 
> ----
> include/trace/events/oom.h:8:13: error: initializer element is not constant
> include/trace/events/oom.h:8:13: error: (near initialization for '__tracepoint_oom_score_adj_update')
> include/trace/events/oom.h:8:13: error: initializer element is not constant
> include/trace/events/oom.h:8:13: error: (near initialization for '__tracepoint_oom_score_adj_update.key')
> ----
> 
> This is caused by that the cast to atomic_t is performed by ATOMIC_INIT of SH.
> However, at almost all the architecture, the cast to atomic_t is not performed by ATOMIC_INIT.

And on other architectures it is. We don't specifically have any need for
using the cast, so dropping it is probably fine, but there are other
architectures that will either have to do the same or the tracing change
that introduced the build failure has to be rethought.