From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/4] sh: sh4: Change the specification method of IRQ to SCIx_IRQ_MUXED
Date: Fri, 18 May 2012 09:11:17 +0000 [thread overview]
Message-ID: <20120518091117.GF24355@linux-sh.org> (raw)
In-Reply-To: <1334286843-3297-2-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>
On Fri, Apr 13, 2012 at 12:14:01PM +0900, Nobuhiro Iwamatsu wrote:
> Some SCIF devices specify the same IRQ. We can use SCIx_IRQ_MUXED for this.
> And change use to evt2irq(), without specifying the value of IRQ directly.
> This is correction to the SH4 series.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
> ---
> arch/sh/kernel/cpu/sh4/setup-sh7750.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/sh/kernel/cpu/sh4/setup-sh7750.c b/arch/sh/kernel/cpu/sh4/setup-sh7750.c
> index 98cc0c7..56b3bdc 100644
> --- a/arch/sh/kernel/cpu/sh4/setup-sh7750.c
> +++ b/arch/sh/kernel/cpu/sh4/setup-sh7750.c
> @@ -43,7 +43,7 @@ static struct plat_sci_port sci_platform_data = {
> .scscr = SCSCR_TE | SCSCR_RE,
> .scbrr_algo_id = SCBRR_ALGO_2,
> .type = PORT_SCI,
> - .irqs = { 23, 23, 23, 0 },
> + .irqs = SCIx_IRQ_MUXED(evt2irq(0xE40)),
> .regshift = 2,
> };
>
23 is actually 0x4e0, 0xe40 would be 98. Fortunately git merge collided
on this while I was merging my evt2irq migration branch, as it's unlikely
anyone would have noticed this for some time..
next prev parent reply other threads:[~2012-05-18 9:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 3:14 [PATCH 2/4] sh: sh4: Change the specification method of IRQ to SCIx_IRQ_MUXED Nobuhiro Iwamatsu
2012-05-18 9:11 ` Paul Mundt [this message]
2012-05-22 6:22 ` Nobuhiro Iwamatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120518091117.GF24355@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).