SUPERH platform development
 help / color / mirror / Atom feed
From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 10/11] ARM: mach-shmobile: armadillo800eva: Add FSI-WM8978 support
Date: Tue, 22 May 2012 03:05:55 +0000	[thread overview]
Message-ID: <20120522030554.GB22483@linux-sh.org> (raw)
In-Reply-To: <874nr9aqxg.wl%kuninori.morimoto.gx@renesas.com>

On Mon, May 21, 2012 at 07:30:06PM -0700, kuninori.morimoto.gx@renesas.com wrote:
> +/*
> + * FIXME !!
> + *
> + * gpio_no_direction
> + *
> + * current gpio frame work doesn't have
> + * the method to control only pull up/down/free.
> + * this function should be replaced by correct gpio function
> + */
> +static void __init gpio_no_direction(u32 addr)
> +{
> +	__raw_writeb(0x00, addr);
> +}
> +
Now that we have 3 instances of the same routine, it's probably about
time to consolidate them in the mach-shmobile gpio.h. While we're at it,
it's probably worth renaming to gpio_direction_none(), so it matches the
other routines. In the future this will be replaced by the pinconf API.

  reply	other threads:[~2012-05-22  3:05 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22  2:30 [PATCH 10/11] ARM: mach-shmobile: armadillo800eva: Add FSI-WM8978 support Kuninori Morimoto
2012-05-22  3:05 ` Paul Mundt [this message]
2012-05-22  4:12 ` Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120522030554.GB22483@linux-sh.org \
    --to=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox