From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 06/27] ARM: shmobile: shareing DMAEngine USBTS_HI/LOW value
Date: Mon, 11 Jun 2012 04:18:40 +0000 [thread overview]
Message-ID: <20120611041839.GF10170@linux-sh.org> (raw)
In-Reply-To: <87ehpmqzc9.wl%kuninori.morimoto.gx@renesas.com>
On Sun, Jun 10, 2012 at 08:52:58PM -0700, Kuninori Morimoto wrote:
> -#define USBTS_INDEX2VAL(i) (((i) & 3) << 6)
> +unsigned int usbts_shift[] = USBTS_SHIFT;
>
This doesn't need to be global.
The wrapping is also pointless, you can rename USBTS_SHIFT to usbts_shift
and provide a static variable declaration in the header.
All of this ts_shift[] = TS_SHIFT stuff is a ridiculous attempt to work
around the type definition, and needs to die.
We did used to do it this way, but I suppose somewhere along the way
someone had a brilliant idea for a "cleanup" that we now have to
propagate this stupidity for.
next prev parent reply other threads:[~2012-06-11 4:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 3:52 [PATCH 06/27] ARM: shmobile: shareing DMAEngine USBTS_HI/LOW value Kuninori Morimoto
2012-06-11 4:18 ` Paul Mundt [this message]
2012-06-11 7:59 ` Simon Horman
2012-06-11 10:01 ` Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120611041839.GF10170@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox