From: Simon Horman <horms@verge.net.au>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-mmc@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] mmc: sh_mmcif: Support MMC_SLEEP_AWAKE command
Date: Wed, 13 Jun 2012 01:12:01 +0000 [thread overview]
Message-ID: <20120613011201.GD16686@verge.net.au> (raw)
In-Reply-To: <1339534569-27923-1-git-send-email-laurent.pinchart@ideasonboard.com>
On Tue, Jun 12, 2012 at 10:56:09PM +0200, Laurent Pinchart wrote:
> The MMC_SLEEP_AWAKE and SD_IO_SEND_OP_COND commands share the same
> opcode. SD_IO_SEND_OP_COND isn't supported by the SH MMCIF, but
> MMC_SLEEP_AWAKE is. Discriminate between the two commands using the
> command flags, and reject SD_IO_SEND_OP_COND only.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/mmc/host/sh_mmcif.c | 14 ++++----------
> 1 files changed, 4 insertions(+), 10 deletions(-)
>
> Not supporting the MMC_SLEEP_AWAKE command makes system suspend fail if an MMC
> or eMMC device supporting sleep/wake is connected. The issue has been first
> noticed on the Armadillo 800 EVA board.
Hi Laurent,
Do you have a test-case for this?
Also, did you check to make sure that the Mackerel still works?
next prev parent reply other threads:[~2012-06-13 1:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 20:56 [PATCH] mmc: sh_mmcif: Support MMC_SLEEP_AWAKE command Laurent Pinchart
2012-06-13 1:12 ` Simon Horman [this message]
2012-06-13 7:39 ` Laurent Pinchart
2012-06-20 6:42 ` Simon Horman
2012-06-20 10:51 ` Laurent Pinchart
2012-06-13 13:27 ` Guennadi Liakhovetski
2012-06-20 6:21 ` Chris Ball
2012-06-20 11:54 ` Ulf Hansson
2012-06-20 13:06 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613011201.GD16686@verge.net.au \
--to=horms@verge.net.au \
--cc=g.liakhovetski@gmx.de \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).