From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Wed, 13 Jun 2012 01:12:01 +0000 Subject: Re: [PATCH] mmc: sh_mmcif: Support MMC_SLEEP_AWAKE command Message-Id: <20120613011201.GD16686@verge.net.au> List-Id: References: <1339534569-27923-1-git-send-email-laurent.pinchart@ideasonboard.com> In-Reply-To: <1339534569-27923-1-git-send-email-laurent.pinchart@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Laurent Pinchart Cc: linux-mmc@vger.kernel.org, Guennadi Liakhovetski , linux-sh@vger.kernel.org On Tue, Jun 12, 2012 at 10:56:09PM +0200, Laurent Pinchart wrote: > The MMC_SLEEP_AWAKE and SD_IO_SEND_OP_COND commands share the same > opcode. SD_IO_SEND_OP_COND isn't supported by the SH MMCIF, but > MMC_SLEEP_AWAKE is. Discriminate between the two commands using the > command flags, and reject SD_IO_SEND_OP_COND only. > > Signed-off-by: Laurent Pinchart > --- > drivers/mmc/host/sh_mmcif.c | 14 ++++---------- > 1 files changed, 4 insertions(+), 10 deletions(-) > > Not supporting the MMC_SLEEP_AWAKE command makes system suspend fail if an MMC > or eMMC device supporting sleep/wake is connected. The issue has been first > noticed on the Armadillo 800 EVA board. Hi Laurent, Do you have a test-case for this? Also, did you check to make sure that the Mackerel still works?