From: Paul Mundt <lethal@linux-sh.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-serial@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/2] serial: sh-sci: Fix probe error paths
Date: Wed, 13 Jun 2012 01:36:52 +0000 [thread overview]
Message-ID: <20120613013652.GK10170@linux-sh.org> (raw)
In-Reply-To: <1339540104-25003-2-git-send-email-laurent.pinchart@ideasonboard.com> <1339540104-25003-1-git-send-email-laurent.pinchart@ideasonboard.com>
On Wed, Jun 13, 2012 at 12:28:23AM +0200, Laurent Pinchart wrote:
> When probing fails, the driver must not try to cleanup resources that
> have not been initialized. Fix this.
On Wed, Jun 13, 2012 at 12:28:24AM +0200, Laurent Pinchart wrote:
> The driver supports a maximum number of ports configurable at compile
> time. Make sure the probe() method fails when registering a port that
> exceeds the maximum instead of returning success without registering the
> port.
>
> This fixes a crash at system suspend time, when the driver tried to
> suspend a non-registered port using the UART core.
Both applied, thanks.
prev parent reply other threads:[~2012-06-13 1:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 22:28 [PATCH 1/2] serial: sh-sci: Fix probe error paths Laurent Pinchart
2012-06-12 22:28 ` [PATCH 2/2] serial: sh-sci: Make probe fail for ports that exceed the maximum count Laurent Pinchart
2012-06-13 1:36 ` Paul Mundt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613013652.GK10170@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).