From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Wed, 20 Jun 2012 04:58:08 +0000 Subject: Re: [PATCH 4/5 v4] mmc: sh_mmcif: remove redundant .down_pwr() callback Message-Id: <20120620045808.GC20030@verge.net.au> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Guennadi Liakhovetski Cc: linux-mmc@vger.kernel.org, linux-sh@vger.kernel.org, Magnus Damm , Chris Ball , Mark Brown On Wed, Jun 13, 2012 at 03:37:27PM +0200, Guennadi Liakhovetski wrote: > >From the original version of sh_mmcif the .set_pwr() callback has only been > used to turn the card's power on, and the .down_pwr() callback has been > used to turn it off. .set_pwr() can be used for both these tasks, which is > also how it is implemented by the only user of this API: the SH7724 ecovec > board. > > Signed-off-by: Guennadi Liakhovetski Reviewed-by: Simon Horman Do you also intend to post patches for the following? * Remove mmcif_down_pwr from ecovec * Remove down_pwr from struct sh_mmcif_plat_data