* [PATCH 02/27 v2] ARM: shmobile: sh7372: bugfix: chclr_offset base
@ 2012-06-12 9:32 Kuninori Morimoto
2012-06-20 9:48 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2012-06-12 9:32 UTC (permalink / raw)
To: linux-sh
chclr_write() will use (chan_reg + chclr_offset).
In sh7372 case, DMA1CHCLR is started from 0xfe008220,
and chan_reg is started from 0xfe008020 (= sh7372_dmae0_resources).
Thus, chclr_offset should be (0x220 - 0x20) instead of 0x220.
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
- no change
arch/arm/mach-shmobile/setup-sh7372.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-shmobile/setup-sh7372.c b/arch/arm/mach-shmobile/setup-sh7372.c
index 6a4bd58..fafce9c 100644
--- a/arch/arm/mach-shmobile/setup-sh7372.c
+++ b/arch/arm/mach-shmobile/setup-sh7372.c
@@ -484,7 +484,7 @@ static const struct sh_dmae_slave_config sh7372_dmae_slaves[] = {
},
};
-#define SH7372_CHCLR 0x220
+#define SH7372_CHCLR (0x220 - 0x20)
static const struct sh_dmae_channel sh7372_dmae_channels[] = {
{
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 02/27 v2] ARM: shmobile: sh7372: bugfix: chclr_offset base
2012-06-12 9:32 [PATCH 02/27 v2] ARM: shmobile: sh7372: bugfix: chclr_offset base Kuninori Morimoto
@ 2012-06-20 9:48 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2012-06-20 9:48 UTC (permalink / raw)
To: linux-sh
On Tuesday, June 12, 2012, Kuninori Morimoto wrote:
> chclr_write() will use (chan_reg + chclr_offset).
> In sh7372 case, DMA1CHCLR is started from 0xfe008220,
> and chan_reg is started from 0xfe008020 (= sh7372_dmae0_resources).
> Thus, chclr_offset should be (0x220 - 0x20) instead of 0x220.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Applied to the fixes branch of the renesas.git tree.
Thanks,
Rafael
> ---
> v1 -> v2
>
> - no change
>
> arch/arm/mach-shmobile/setup-sh7372.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/setup-sh7372.c b/arch/arm/mach-shmobile/setup-sh7372.c
> index 6a4bd58..fafce9c 100644
> --- a/arch/arm/mach-shmobile/setup-sh7372.c
> +++ b/arch/arm/mach-shmobile/setup-sh7372.c
> @@ -484,7 +484,7 @@ static const struct sh_dmae_slave_config sh7372_dmae_slaves[] = {
> },
> };
>
> -#define SH7372_CHCLR 0x220
> +#define SH7372_CHCLR (0x220 - 0x20)
>
> static const struct sh_dmae_channel sh7372_dmae_channels[] = {
> {
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-20 9:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-12 9:32 [PATCH 02/27 v2] ARM: shmobile: sh7372: bugfix: chclr_offset base Kuninori Morimoto
2012-06-20 9:48 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).