SUPERH platform development
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 04/10 v3] ARM: mach-shmobile: add fixed voltage regulators to armadillo800eva
Date: Thu, 28 Jun 2012 20:17:35 +0000	[thread overview]
Message-ID: <201206282217.35474.rjw@sisk.pl> (raw)
In-Reply-To: <1340749952-8534-5-git-send-email-g.liakhovetski@gmx.de>

On Wednesday, June 27, 2012, Guennadi Liakhovetski wrote:
> On Wed, 27 Jun 2012, Guennadi Liakhovetski wrote:
> 
> > On armadillo800eva provide a 3.3V supply for its SD/MMC-card interfaces.
> > 
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > ---
> >  arch/arm/mach-shmobile/board-armadillo800eva.c |   16 ++++++++++++++++
> >  1 files changed, 16 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-shmobile/board-armadillo800eva.c b/arch/arm/mach-shmobile/board-armadillo800eva.c
> > index 9e37026..819cee5 100644
> > --- a/arch/arm/mach-shmobile/board-armadillo800eva.c
> > +++ b/arch/arm/mach-shmobile/board-armadillo800eva.c
> > @@ -28,6 +28,8 @@
> >  #include <linux/platform_device.h>
> >  #include <linux/gpio.h>
> >  #include <linux/gpio_keys.h>
> > +#include <linux/regulator/fixed.h>
> > +#include <linux/regulator/machine.h>
> >  #include <linux/sh_eth.h>
> >  #include <linux/videodev2.h>
> >  #include <linux/usb/renesas_usbhs.h>
> > @@ -407,6 +409,17 @@ static struct platform_device gpio_keys_device = {
> >  	},
> >  };
> >  
> > +/* Fixed 3.3V regulator to be used by SDHI0, SDHI1, MMCIF */
> > +static struct regulator_consumer_supply fixed3v3_power_consumers[] > > +{
> > +	REGULATOR_SUPPLY("vmmc", "sh_mobile_sdhi.0"),
> > +	REGULATOR_SUPPLY("vqmmc", "sh_mobile_sdhi.0"),
> > +	REGULATOR_SUPPLY("vmmc", "sh_mobile_sdhi.1"),
> > +	REGULATOR_SUPPLY("vqmmc", "sh_mobile_sdhi.1"),
> > +	REGULATOR_SUPPLY("vmmc", "sh_mmcif.0"),
> > +	REGULATOR_SUPPLY("vqmmc", "sh_mmcif.0"),
> 
> There is a slight problem with this patch: a1 (r8a7740) SoCs are currently 
> the only ones registering their MMCIF device without an index, i.e., with 
> .id = -1. This is reflected in board-armadillo800eva.c and in 
> clock-r8a7740.c. This patch erroneously uses sh_mmcif.0 for device name, 
> which is also what every single other ARM and sh platform in the mainline, 
> using mmcif, AFAICS, currently does.
> 
> Therefore question: Magnus, Rafael: what would you prefer - fix the above 
> regulator entries to not use a device ID, or unify a1 with other SoCs to 
> use .id = 0?

I wonder what's going to be more straightforward?

Rafael

  parent reply	other threads:[~2012-06-28 20:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 22:32 [PATCH 04/10 v3] ARM: mach-shmobile: add fixed voltage regulators to armadillo800eva Guennadi Liakhovetski
2012-06-27 15:56 ` Guennadi Liakhovetski
2012-06-28 20:17 ` Rafael J. Wysocki [this message]
2012-06-28 23:57 ` Magnus Damm
2012-06-29  7:49 ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201206282217.35474.rjw@sisk.pl \
    --to=rjw@sisk.pl \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox