* Re: [PATCH][rework] ARM: shmobile: patch set rework
2012-06-25 10:28 [PATCH][rework] ARM: shmobile: patch set rework Kuninori Morimoto
@ 2012-06-25 16:13 ` Magnus Damm
2012-06-28 20:56 ` Rafael J. Wysocki
` (4 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Magnus Damm @ 2012-06-25 16:13 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
On Mon, Jun 25, 2012 at 7:28 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
> Hi Rafael, Magnus
> Cc Simon
>
> These are rework patch set which are not included on latest rafael's tree.
> (and additional patch)
> I separated each patches to become independent as much as possible.
Thanks for splitting out your patches!
> My previous patch set tried to sharing "gpio" and "DMAEngine" definitions on top.
> This patch set still try to sharing it, but it was on last patches.
Good plan. I like when you prioritize adding hardware support over
moving around code. =)
> gpio/DMAEngine sharing patch were separated as "add common xxx",
> and "use common xxx".
> I hope it is good fit for rafael's branch control
Looks fine to me, but I will let Rafael decide about that.
> 1st "PM domain" patch is new one.
> It adds very basic PM domain support for Armadillo
>
> Kuninori Morimoto (1):
> ARM: shmobile: r8a7740: basic PM domain support
I believe this one needs more work. So I prefer holding off on this
for a while, alternatively including it in some topic branch for
incremental fixing and possible rebase,
> Kuninori Morimoto (2):
> ARM: shmobile: armadillo800eva: enable FSI-WM8978 sound
> ARM: shmobile: armadillo800eva: enable FSI-HDMI sound
>
> Kuninori Morimoto (3):
> ARM: shmobile: sh73a0: add USB clock support
> ARM: shmobile: kzm9g: enable USB func
> ARM: shmobile: kzm9g: enable MicroSD
>
> Kuninori Morimoto (6):
> ARM: shmobile: r8a7740: add DMAEngine support for FSI
> ARM: shmobile: r8a7740: add DMAEngine support for SDHI
> ARM: shmobile: r8a7740: add DMAEngine support for USB
> ARM: shmobile: armadillo800eva: enable DMAEngine on FSI
> ARM: shmobile: armadillo800eva: enable DMAEngine on SDHI
> ARM: shmobile: armadillo800eva: enable DMAEngine on USB
>
> Kuninori Morimoto (3):
> ARM: shmobile: sh73a0: add DMAEngine support for MPDMAC
> ARM: shmobile: kzm9g: enable DMAEngine on FSI
> ARM: shmobile: kzm9g: enable DMAEngine on MMCIF
>
> Kuninori Morimoto (5):
> ARM: shmobile: add common extra gpio functions
> ARM: shmobile: use common extra gpio functions on ap4evb
> ARM: shmobile: use common extra gpio functions on g4evm
> ARM: shmobile: use common extra gpio functions on mackrel
> ARM: shmobile: use common extra gpio functions on armadillo800eva
>
> Kuninori Morimoto (4):
> ARM: shmobile: add common DMAEngine definitions
> ARM: shmobile: use common DMAEngine definitions on r8a7740
> ARM: shmobile: use common DMAEngine definitions on sh7372
> ARM: shmobile: use common DMAEngine definitions on sh73a0
These all look fine to me. Thanks for reposting your patches.
Rafael, please feel free to include my acked-by and pick up unless you
or someone else thinks differently.
Morimoto-san, in general I'm happy with you resending your patches
like this time, and I'm not sure if you can easily change the format
of this kind of email, but to make your patches even more easy to read
please consider:
a) including a diffstat in each [PATCH 0/x] (this is good to show why
the cleanup is useful)
b) include the [PATCH x/y] information in your patch list included in
[PATCH 0/x] (and this email)
Cheers,
/ magnus
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH][rework] ARM: shmobile: patch set rework
2012-06-25 10:28 [PATCH][rework] ARM: shmobile: patch set rework Kuninori Morimoto
2012-06-25 16:13 ` Magnus Damm
@ 2012-06-28 20:56 ` Rafael J. Wysocki
2012-06-29 2:18 ` Kuninori Morimoto
` (3 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2012-06-28 20:56 UTC (permalink / raw)
To: linux-sh
On Monday, June 25, 2012, Magnus Damm wrote:
> Hi Morimoto-san,
>
> On Mon, Jun 25, 2012 at 7:28 PM, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> >
> > Hi Rafael, Magnus
> > Cc Simon
> >
> > These are rework patch set which are not included on latest rafael's tree.
> > (and additional patch)
> > I separated each patches to become independent as much as possible.
>
> Thanks for splitting out your patches!
>
> > My previous patch set tried to sharing "gpio" and "DMAEngine" definitions on top.
> > This patch set still try to sharing it, but it was on last patches.
>
> Good plan. I like when you prioritize adding hardware support over
> moving around code. =)
>
> > gpio/DMAEngine sharing patch were separated as "add common xxx",
> > and "use common xxx".
> > I hope it is good fit for rafael's branch control
>
> Looks fine to me, but I will let Rafael decide about that.
>
> > 1st "PM domain" patch is new one.
> > It adds very basic PM domain support for Armadillo
> >
> > Kuninori Morimoto (1):
> > ARM: shmobile: r8a7740: basic PM domain support
>
> I believe this one needs more work. So I prefer holding off on this
> for a while, alternatively including it in some topic branch for
> incremental fixing and possible rebase,
>
> > Kuninori Morimoto (2):
> > ARM: shmobile: armadillo800eva: enable FSI-WM8978 sound
> > ARM: shmobile: armadillo800eva: enable FSI-HDMI sound
> >
> > Kuninori Morimoto (3):
> > ARM: shmobile: sh73a0: add USB clock support
> > ARM: shmobile: kzm9g: enable USB func
> > ARM: shmobile: kzm9g: enable MicroSD
> >
> > Kuninori Morimoto (6):
> > ARM: shmobile: r8a7740: add DMAEngine support for FSI
> > ARM: shmobile: r8a7740: add DMAEngine support for SDHI
> > ARM: shmobile: r8a7740: add DMAEngine support for USB
> > ARM: shmobile: armadillo800eva: enable DMAEngine on FSI
> > ARM: shmobile: armadillo800eva: enable DMAEngine on SDHI
> > ARM: shmobile: armadillo800eva: enable DMAEngine on USB
> >
> > Kuninori Morimoto (3):
> > ARM: shmobile: sh73a0: add DMAEngine support for MPDMAC
> > ARM: shmobile: kzm9g: enable DMAEngine on FSI
> > ARM: shmobile: kzm9g: enable DMAEngine on MMCIF
> >
> > Kuninori Morimoto (5):
> > ARM: shmobile: add common extra gpio functions
> > ARM: shmobile: use common extra gpio functions on ap4evb
> > ARM: shmobile: use common extra gpio functions on g4evm
> > ARM: shmobile: use common extra gpio functions on mackrel
> > ARM: shmobile: use common extra gpio functions on armadillo800eva
> >
> > Kuninori Morimoto (4):
> > ARM: shmobile: add common DMAEngine definitions
> > ARM: shmobile: use common DMAEngine definitions on r8a7740
> > ARM: shmobile: use common DMAEngine definitions on sh7372
> > ARM: shmobile: use common DMAEngine definitions on sh73a0
>
> These all look fine to me. Thanks for reposting your patches.
>
> Rafael, please feel free to include my acked-by and pick up unless you
> or someone else thinks differently.
>
> Morimoto-san, in general I'm happy with you resending your patches
> like this time,
Sorry to say that, but it totally doesn't work for me.
I'd prefer it to be a single patch series organized so that:
(1) Patches that multiple SoCs depend on go first
(e.g. "ARM: shmobile: add common extra gpio functions" above).
(2) Patches that only one SoC depends on, but that touch files common to
multiple boards go next
(e.g. "ARM: shmobile: use common DMAEngine definitions on r8a7740" above).
(3) Patches that touch only one individual board go last
(e.g. "ARM: shmobile: use common extra gpio functions on mackrel" above).
Pretty much any other ordering adds work for me and causes a lot of pain if
things don't apply cleanly to the branches I'm using (which is the case this
time).
Thanks,
Rafael
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH][rework] ARM: shmobile: patch set rework
2012-06-25 10:28 [PATCH][rework] ARM: shmobile: patch set rework Kuninori Morimoto
2012-06-25 16:13 ` Magnus Damm
2012-06-28 20:56 ` Rafael J. Wysocki
@ 2012-06-29 2:18 ` Kuninori Morimoto
2012-06-30 14:09 ` Rafael J. Wysocki
` (2 subsequent siblings)
5 siblings, 0 replies; 7+ messages in thread
From: Kuninori Morimoto @ 2012-06-29 2:18 UTC (permalink / raw)
To: linux-sh
Hi Rafael
> Sorry to say that, but it totally doesn't work for me.
>
> I'd prefer it to be a single patch series organized so that:
> (1) Patches that multiple SoCs depend on go first
> (e.g. "ARM: shmobile: add common extra gpio functions" above).
> (2) Patches that only one SoC depends on, but that touch files common to
> multiple boards go next
> (e.g. "ARM: shmobile: use common DMAEngine definitions on r8a7740" above).
> (3) Patches that touch only one individual board go last
> (e.g. "ARM: shmobile: use common extra gpio functions on mackrel" above).
OK.
My understanding is
(1) -> for rafael/soc => rafael/soc'
(2) -> for rafael/r8a7740 + rafael/soc' => rafael/r8a7740'
-> for rafael/sh73a0 + rafael/soc' => rafael/sh73a0'
(3) -> for rafael/armadillo + rafael/r8a7740' => rafael/armadillo'
-> for rafael/kzm9g + rafael/sh73a0' => rafael/kzm9g'
Is this correct ?
If so, v2 patch set will be...
------- for rafael/soc ----------------------------------
Kuninori Morimoto (1):
[PATCH 1/1] ARM: shmobile: shareing extra gpio setting functions
arch/arm/mach-shmobile/board-ap4evb.c | 19 +--------------
arch/arm/mach-shmobile/board-g4evm.c | 18 ---------------
arch/arm/mach-shmobile/board-mackerel.c | 30 +------------------------
arch/arm/mach-shmobile/include/mach/gpio.h | 32 ++++++++++++++++++++++++++++
4 files changed, 36 insertions(+), 63 deletions(-)
------- for rafael/soc ----------------------------------
Kuninori Morimoto (3):
[PATCH 1/3] ARM: shmobile: shareing DMAEngine definitions
[PATCH 2/3] ARM: shmobile: shareing DMAEngine TS_HI/LOW value
[PATCH 3/3] ARM: shmobile: shareing DMAEngine USBTS_HI/LOW value
arch/arm/mach-shmobile/include/mach/dma-register.h | 84 +++++++++++++
arch/arm/mach-shmobile/setup-sh7372.c | 131 +++++++-------------
arch/arm/mach-shmobile/setup-sh73a0.c | 41 +-----
3 files changed, 138 insertions(+), 118 deletions(-)
------- for rafael/r8a7740 ----------------------------------
Kuninori Morimoto (3):
[PATCH 1/3] ARM: shmobile: r8a7740: add DMAEngine support for FSI
[PATCH 2/3] ARM: shmobile: r8a7740: add DMAEngine support for SDHI
[PATCH 3/3] ARM: shmobile: r8a7740: add DMAEngine support for USB
arch/arm/mach-shmobile/clock-r8a7740.c | 10 +-
arch/arm/mach-shmobile/include/mach/r8a7740.h | 16 ++
arch/arm/mach-shmobile/setup-r8a7740.c | 273 +++++++++++++++++++++++++
3 files changed, 298 insertions(+), 1 deletions(-)
------- for rafael/sh73a0 ----------------------------------
Kuninori Morimoto (2):
[PATCH 1/2] ARM: shmobile: sh73a0: add DMAEngine support for MPDMAC
[PATCH 2/2] ARM: shmobile: sh73a0: add USB clock support
arch/arm/mach-shmobile/clock-sh73a0.c | 8 ++-
arch/arm/mach-shmobile/include/mach/sh73a0.h | 7 ++
arch/arm/mach-shmobile/setup-sh73a0.c | 111 ++++++++++++++++++++++++++
3 files changed, 124 insertions(+), 2 deletions(-)
------- for rafael/armadillo ----------------------------------
Kuninori Morimoto (5):
[PATCH 1/5] ARM: shmobile: armadillo800eva: enable FSI-WM8978 sound
[PATCH 2/5] ARM: shmobile: armadillo800eva: enable FSI-HDMI sound
[PATCH 3/5] ARM: shmobile: armadillo800eva: enable DMAEngine on FSI
[PATCH 4/5] ARM: shmobile: armadillo800eva: enable DMAEngine on SDHI
[PATCH 5/5] ARM: shmobile: armadillo800eva: enable DMAEngine on USB
arch/arm/configs/armadillo800eva_defconfig | 2 +
arch/arm/mach-shmobile/Kconfig | 1 +
arch/arm/mach-shmobile/board-armadillo800eva.c | 175 +++++++++++++++++++++++-
3 files changed, 175 insertions(+), 3 deletions(-)
------- for rafael/kzm9g ----------------------------------
Kuninori Morimoto (4):
[PATCH 1/4] ARM: shmobile: kzm9g: enable DMAEngine on FSI
[PATCH 2/4] ARM: shmobile: kzm9g: enable DMAEngine on MMCIF
[PATCH 3/4] ARM: shmobile: kzm9g: enable USB func
[PATCH 4/4] ARM: shmobile: kzm9g: enable MicroSD
arch/arm/configs/kzm9g_defconfig | 5 +
arch/arm/mach-shmobile/board-kzm9g.c | 208 ++++++++++++++++++++++++++++++++++
2 files changed, 213 insertions(+), 0 deletions(-)
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH][rework] ARM: shmobile: patch set rework
2012-06-25 10:28 [PATCH][rework] ARM: shmobile: patch set rework Kuninori Morimoto
` (2 preceding siblings ...)
2012-06-29 2:18 ` Kuninori Morimoto
@ 2012-06-30 14:09 ` Rafael J. Wysocki
2012-07-02 0:47 ` Kuninori Morimoto
2012-07-02 19:53 ` Rafael J. Wysocki
5 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2012-06-30 14:09 UTC (permalink / raw)
To: linux-sh
Hi Morimoto-san,
I've already merged your entire seres doing some manula adjustments
wherever the changes depended on the new PM domain code. Please
check the 'next' branch of the renesas.git tree and let me know if
anything is missing or wrong.
On Friday, June 29, 2012, Kuninori Morimoto wrote:
>
> Hi Rafael
>
> > Sorry to say that, but it totally doesn't work for me.
> >
> > I'd prefer it to be a single patch series organized so that:
> > (1) Patches that multiple SoCs depend on go first
> > (e.g. "ARM: shmobile: add common extra gpio functions" above).
> > (2) Patches that only one SoC depends on, but that touch files common to
> > multiple boards go next
> > (e.g. "ARM: shmobile: use common DMAEngine definitions on r8a7740" above).
> > (3) Patches that touch only one individual board go last
> > (e.g. "ARM: shmobile: use common extra gpio functions on mackrel" above).
>
> OK.
> My understanding is
>
> (1) -> for rafael/soc => rafael/soc'
That would be renesas.git/soc-core
> (2) -> for rafael/r8a7740 + rafael/soc' => rafael/r8a7740'
> -> for rafael/sh73a0 + rafael/soc' => rafael/sh73a0'
> (3) -> for rafael/armadillo + rafael/r8a7740' => rafael/armadillo'
> -> for rafael/kzm9g + rafael/sh73a0' => rafael/kzm9g'
>
> Is this correct ?
Yes, it is, except that the 'soc' branch should be replaced with 'soc-core'
everywhere above.
> If so, v2 patch set will be...
>
> ------- for rafael/soc ----------------------------------
> Kuninori Morimoto (1):
> [PATCH 1/1] ARM: shmobile: shareing extra gpio setting functions
>
> arch/arm/mach-shmobile/board-ap4evb.c | 19 +--------------
> arch/arm/mach-shmobile/board-g4evm.c | 18 ---------------
> arch/arm/mach-shmobile/board-mackerel.c | 30 +------------------------
> arch/arm/mach-shmobile/include/mach/gpio.h | 32 ++++++++++++++++++++++++++++
> 4 files changed, 36 insertions(+), 63 deletions(-)
No, that should be split into 4 patches, such that patch 1 will change
arch/arm/mach-shmobile/include/mach/gpio.h only and the other patches will
change the respective board files. You've done the split already, haven't you?
>
> ------- for rafael/soc ----------------------------------
> Kuninori Morimoto (3):
> [PATCH 1/3] ARM: shmobile: shareing DMAEngine definitions
> [PATCH 2/3] ARM: shmobile: shareing DMAEngine TS_HI/LOW value
> [PATCH 3/3] ARM: shmobile: shareing DMAEngine USBTS_HI/LOW value
I'm not sure I've seen these three?
> arch/arm/mach-shmobile/include/mach/dma-register.h | 84 +++++++++++++
> arch/arm/mach-shmobile/setup-sh7372.c | 131 +++++++-------------
> arch/arm/mach-shmobile/setup-sh73a0.c | 41 +-----
> 3 files changed, 138 insertions(+), 118 deletions(-)
>
> ------- for rafael/r8a7740 ----------------------------------
> Kuninori Morimoto (3):
> [PATCH 1/3] ARM: shmobile: r8a7740: add DMAEngine support for FSI
> [PATCH 2/3] ARM: shmobile: r8a7740: add DMAEngine support for SDHI
> [PATCH 3/3] ARM: shmobile: r8a7740: add DMAEngine support for USB
>
> arch/arm/mach-shmobile/clock-r8a7740.c | 10 +-
> arch/arm/mach-shmobile/include/mach/r8a7740.h | 16 ++
> arch/arm/mach-shmobile/setup-r8a7740.c | 273 +++++++++++++++++++++++++
> 3 files changed, 298 insertions(+), 1 deletions(-)
>
> ------- for rafael/sh73a0 ----------------------------------
> Kuninori Morimoto (2):
> [PATCH 1/2] ARM: shmobile: sh73a0: add DMAEngine support for MPDMAC
> [PATCH 2/2] ARM: shmobile: sh73a0: add USB clock support
>
> arch/arm/mach-shmobile/clock-sh73a0.c | 8 ++-
> arch/arm/mach-shmobile/include/mach/sh73a0.h | 7 ++
> arch/arm/mach-shmobile/setup-sh73a0.c | 111 ++++++++++++++++++++++++++
> 3 files changed, 124 insertions(+), 2 deletions(-)
>
> ------- for rafael/armadillo ----------------------------------
> Kuninori Morimoto (5):
> [PATCH 1/5] ARM: shmobile: armadillo800eva: enable FSI-WM8978 sound
> [PATCH 2/5] ARM: shmobile: armadillo800eva: enable FSI-HDMI sound
> [PATCH 3/5] ARM: shmobile: armadillo800eva: enable DMAEngine on FSI
> [PATCH 4/5] ARM: shmobile: armadillo800eva: enable DMAEngine on SDHI
> [PATCH 5/5] ARM: shmobile: armadillo800eva: enable DMAEngine on USB
>
> arch/arm/configs/armadillo800eva_defconfig | 2 +
> arch/arm/mach-shmobile/Kconfig | 1 +
> arch/arm/mach-shmobile/board-armadillo800eva.c | 175 +++++++++++++++++++++++-
> 3 files changed, 175 insertions(+), 3 deletions(-)
>
> ------- for rafael/kzm9g ----------------------------------
> Kuninori Morimoto (4):
> [PATCH 1/4] ARM: shmobile: kzm9g: enable DMAEngine on FSI
> [PATCH 2/4] ARM: shmobile: kzm9g: enable DMAEngine on MMCIF
> [PATCH 3/4] ARM: shmobile: kzm9g: enable USB func
> [PATCH 4/4] ARM: shmobile: kzm9g: enable MicroSD
>
> arch/arm/configs/kzm9g_defconfig | 5 +
> arch/arm/mach-shmobile/board-kzm9g.c | 208 ++++++++++++++++++++++++++++++++++
> 2 files changed, 213 insertions(+), 0 deletions(-)
Well, why don't you create a _single_ series, like:
[PATCH 1/16] ARM: shmobile: add common DMAEngine definitions
[PATCH 2/16] ARM: shmobile: add common extra gpio functions
[PATCH 3/16] ARM: shmobile: r8a7740: add DMAEngine support for FSI
[PATCH 4/16] ARM: shmobile: r8a7740: add DMAEngine support for SDHI
[PATCH 5/16] ARM: shmobile: r8a7740: add DMAEngine support for USB
[PATCH 6/16] ARM: shmobile: sh73a0: add DMAEngine support for MPDMAC
[PATCH 7/16] ARM: shmobile: sh73a0: add USB clock support
[PATCH 8/16] ARM: shmobile: armadillo800eva: enable FSI-WM8978 sound
[PATCH 9/16] ARM: shmobile: armadillo800eva: enable FSI-HDMI sound
[PATCH 10/16] ARM: shmobile: armadillo800eva: enable DMAEngine on FSI
[PATCH 11/16] ARM: shmobile: armadillo800eva: enable DMAEngine on SDHI
[PATCH 12/16] ARM: shmobile: armadillo800eva: enable DMAEngine on USB
[PATCH 13/16] ARM: shmobile: kzm9g: enable DMAEngine on FSI
[PATCH 14/16] ARM: shmobile: kzm9g: enable DMAEngine on MMCIF
[PATCH 15/16] ARM: shmobile: kzm9g: enable USB func
[PATCH 16/16] ARM: shmobile: kzm9g: enable MicroSD
next time? That will be _way_ easier for me to handle and generally quite
clean, and you can always add a [0/16] message explaining what's going on.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH][rework] ARM: shmobile: patch set rework
2012-06-25 10:28 [PATCH][rework] ARM: shmobile: patch set rework Kuninori Morimoto
` (3 preceding siblings ...)
2012-06-30 14:09 ` Rafael J. Wysocki
@ 2012-07-02 0:47 ` Kuninori Morimoto
2012-07-02 19:53 ` Rafael J. Wysocki
5 siblings, 0 replies; 7+ messages in thread
From: Kuninori Morimoto @ 2012-07-02 0:47 UTC (permalink / raw)
To: linux-sh
Hi Rafael
> I've already merged your entire seres doing some manula adjustments
> wherever the changes depended on the new PM domain code. Please
> check the 'next' branch of the renesas.git tree and let me know if
> anything is missing or wrong.
Thank you for accepting my patches.
Yes. Its are correctly included in my quick check.
> > ------- for rafael/soc ----------------------------------
> > Kuninori Morimoto (1):
> > [PATCH 1/1] ARM: shmobile: shareing extra gpio setting functions
> >
> > arch/arm/mach-shmobile/board-ap4evb.c | 19 +--------------
> > arch/arm/mach-shmobile/board-g4evm.c | 18 ---------------
> > arch/arm/mach-shmobile/board-mackerel.c | 30 +------------------------
> > arch/arm/mach-shmobile/include/mach/gpio.h | 32 ++++++++++++++++++++++++++++
> > 4 files changed, 36 insertions(+), 63 deletions(-)
>
> No, that should be split into 4 patches, such that patch 1 will change
> arch/arm/mach-shmobile/include/mach/gpio.h only and the other patches will
> change the respective board files. You've done the split already, haven't you?
(snip)
> [PATCH 1/16] ARM: shmobile: add common DMAEngine definitions
> [PATCH 2/16] ARM: shmobile: add common extra gpio functions
> [PATCH 3/16] ARM: shmobile: r8a7740: add DMAEngine support for FSI
> [PATCH 4/16] ARM: shmobile: r8a7740: add DMAEngine support for SDHI
> [PATCH 5/16] ARM: shmobile: r8a7740: add DMAEngine support for USB
> [PATCH 6/16] ARM: shmobile: sh73a0: add DMAEngine support for MPDMAC
> [PATCH 7/16] ARM: shmobile: sh73a0: add USB clock support
> [PATCH 8/16] ARM: shmobile: armadillo800eva: enable FSI-WM8978 sound
> [PATCH 9/16] ARM: shmobile: armadillo800eva: enable FSI-HDMI sound
> [PATCH 10/16] ARM: shmobile: armadillo800eva: enable DMAEngine on FSI
> [PATCH 11/16] ARM: shmobile: armadillo800eva: enable DMAEngine on SDHI
> [PATCH 12/16] ARM: shmobile: armadillo800eva: enable DMAEngine on USB
> [PATCH 13/16] ARM: shmobile: kzm9g: enable DMAEngine on FSI
> [PATCH 14/16] ARM: shmobile: kzm9g: enable DMAEngine on MMCIF
> [PATCH 15/16] ARM: shmobile: kzm9g: enable USB func
> [PATCH 16/16] ARM: shmobile: kzm9g: enable MicroSD
>
> next time? That will be _way_ easier for me to handle and generally quite
> clean, and you can always add a [0/16] message explaining what's going on.
Sorry it was my English misunderstanding.
I will do that.
I think [PATCH 1/16] and [PATCH 2/16] should be separated into 4 patches for each CPU.
Is this correct ?
But I still have question about this.
What it difference between above style and my original patch set
(= 10 Jun 2012 / [PATCH 0/27] ARM: shmobile: resend patch set)?
There are patch name issue now, and 1st/2nd were bugfix patches,
but...
Kuninori Morimoto (27):
ARM: shmobile: sh73a0: bugfix: SY-DMAC number
ARM: shmobile: sh7372: bugfix: chclr_offset base
ARM: shmobile: shareing extra gpio setting functions
ARM: shmobile: shareing DMAEngine definitions
ARM: shmobile: shareing DMAEngine TS_HI/LOW value
ARM: shmobile: shareing DMAEngine USBTS_HI/LOW value
ARM: shmobile: r8a7740: add HDMI interrupt support
ARM: shmobile: r8a7740: add HDMI clock support
ARM: shmobile: r8a7740: add HDMI GPIO support
ARM: shmobile: r8a7740: add MERAM work-around
ARM: shmobile: r8a7740: add CEU clock support
ARM: shmobile: r8a7740: add FSI parent clock support
ARM: shmobile: r8a7740: add FSI-B (for HDMI) GPIO support
ARM: shmobile: r8a7740: add DMAEngine support for FSI
ARM: shmobile: r8a7740: add DMAEngine support for SDHI
ARM: shmobile: r8a7740: add DMAEngine support for USB
ARM: shmobile: armadillo800eva: enable HDMI
ARM: shmobile: armadillo800eva: enable camera
ARM: shmobile: armadillo800eva: enable FSI-WM8978 sound
ARM: shmobile: armadillo800eva: enable FSI-HDMI sound
ARM: shmobile: armadillo800eva: enable DMAEngine on FSI
ARM: shmobile: armadillo800eva: enable DMAEngine on SDHI
ARM: shmobile: armadillo800eva: enable DMAEngine on USB
ARM: shmobile: sh73a0: add DMAEngine support for MPDMAC
ARM: shmobile: sh73a0: add FSI clock
ARM: shmobile: kzm9g: enable FSI-AK4648
ARM: shmobile: kzm9g: enable DMAEngine on FSI
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH][rework] ARM: shmobile: patch set rework
2012-06-25 10:28 [PATCH][rework] ARM: shmobile: patch set rework Kuninori Morimoto
` (4 preceding siblings ...)
2012-07-02 0:47 ` Kuninori Morimoto
@ 2012-07-02 19:53 ` Rafael J. Wysocki
5 siblings, 0 replies; 7+ messages in thread
From: Rafael J. Wysocki @ 2012-07-02 19:53 UTC (permalink / raw)
To: linux-sh
On Monday, July 02, 2012, Kuninori Morimoto wrote:
>
> Hi Rafael
>
> > I've already merged your entire seres doing some manula adjustments
> > wherever the changes depended on the new PM domain code. Please
> > check the 'next' branch of the renesas.git tree and let me know if
> > anything is missing or wrong.
>
> Thank you for accepting my patches.
> Yes. Its are correctly included in my quick check.
>
> > > ------- for rafael/soc ----------------------------------
> > > Kuninori Morimoto (1):
> > > [PATCH 1/1] ARM: shmobile: shareing extra gpio setting functions
> > >
> > > arch/arm/mach-shmobile/board-ap4evb.c | 19 +--------------
> > > arch/arm/mach-shmobile/board-g4evm.c | 18 ---------------
> > > arch/arm/mach-shmobile/board-mackerel.c | 30 +------------------------
> > > arch/arm/mach-shmobile/include/mach/gpio.h | 32 ++++++++++++++++++++++++++++
> > > 4 files changed, 36 insertions(+), 63 deletions(-)
> >
> > No, that should be split into 4 patches, such that patch 1 will change
> > arch/arm/mach-shmobile/include/mach/gpio.h only and the other patches will
> > change the respective board files. You've done the split already, haven't you?
> (snip)
> > [PATCH 1/16] ARM: shmobile: add common DMAEngine definitions
> > [PATCH 2/16] ARM: shmobile: add common extra gpio functions
> > [PATCH 3/16] ARM: shmobile: r8a7740: add DMAEngine support for FSI
> > [PATCH 4/16] ARM: shmobile: r8a7740: add DMAEngine support for SDHI
> > [PATCH 5/16] ARM: shmobile: r8a7740: add DMAEngine support for USB
> > [PATCH 6/16] ARM: shmobile: sh73a0: add DMAEngine support for MPDMAC
> > [PATCH 7/16] ARM: shmobile: sh73a0: add USB clock support
> > [PATCH 8/16] ARM: shmobile: armadillo800eva: enable FSI-WM8978 sound
> > [PATCH 9/16] ARM: shmobile: armadillo800eva: enable FSI-HDMI sound
> > [PATCH 10/16] ARM: shmobile: armadillo800eva: enable DMAEngine on FSI
> > [PATCH 11/16] ARM: shmobile: armadillo800eva: enable DMAEngine on SDHI
> > [PATCH 12/16] ARM: shmobile: armadillo800eva: enable DMAEngine on USB
> > [PATCH 13/16] ARM: shmobile: kzm9g: enable DMAEngine on FSI
> > [PATCH 14/16] ARM: shmobile: kzm9g: enable DMAEngine on MMCIF
> > [PATCH 15/16] ARM: shmobile: kzm9g: enable USB func
> > [PATCH 16/16] ARM: shmobile: kzm9g: enable MicroSD
> >
> > next time? That will be _way_ easier for me to handle and generally quite
> > clean, and you can always add a [0/16] message explaining what's going on.
>
> Sorry it was my English misunderstanding.
> I will do that.
>
> I think [PATCH 1/16] and [PATCH 2/16] should be separated into 4 patches for each CPU.
> Is this correct ?
>
> But I still have question about this.
> What it difference between above style and my original patch set
> (= 10 Jun 2012 / [PATCH 0/27] ARM: shmobile: resend patch set)?
>
> There are patch name issue now, and 1st/2nd were bugfix patches,
> but...
If I remember correctly, there were patches in there that touch
several boards at a time along with a common header. And there
were patches that required some adjustments, as far as I can say.
Anyway, the format is suitable for me.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 7+ messages in thread