From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: kzm9g: add REGULATOR settings to kzm9g_defconfig
Date: Wed, 04 Jul 2012 10:40:56 +0000 [thread overview]
Message-ID: <201207041240.56586.rjw@sisk.pl> (raw)
In-Reply-To: <4FF2C282.5030000@kmckk.co.jp>
On Wednesday, July 04, 2012, Guennadi Liakhovetski wrote:
> Paul, Magnus, Rafael
>
> What do you think about this? Shall we force the fixed regulator globally
> on for sh and sh-mobile, shall we only force it on for affected boards, or
> shall we leave it to the user to shoot themselves in the foot? In general
> we're not trying to force all Kconfig options on, that a board needs.
> There are enough ways to have a non-working configuration. E.g., you can
> leave off the sh I2C driver. Arguably, having to enable the fixed voltage
> regulator is less obvious, than needing a correct I2C bus driver.
>
> I think I would go with
>
> select REGULATOR_FIXED_VOLTAGE if REGULATOR
>
> - ideally on a per-board basis, or arch-wide. Mark doesn't favour at least
> the latter of these options, IIUC. So, maybe adding entries to defconfigs
> would indeed sufice for now (but no dummy regulator!)
Well, if arch-wide, then perhaps we don't need REGULATOR_FIXED_VOLTAGE at all
and we can just make things depending on it depend on REGULATOR directly?
The meaning of what you're proposing above is pretty much
"REGULATOR_FIXED_VOLTAGE should be set whenever REGULATOR is" and I guess
REGULATOR_FIXED_VOLTAGE depends on REGULATOR, so they appear to be equivalent.
How much code does really depend on REGULATOR_FIXED_VOLTAGE which is not build
when REGULATOR is set?
Thanks,
Rafael
next prev parent reply other threads:[~2012-07-04 10:40 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-03 9:59 [PATCH] ARM: shmobile: kzm9g: add REGULATOR settings to kzm9g_defconfig Tetsuyuki Kobayashi
2012-07-03 10:06 ` Mark Brown
2012-07-03 10:12 ` Guennadi Liakhovetski
2012-07-03 10:31 ` Tetsuyuki Kobayashi
2012-07-03 11:15 ` Tetsuyuki Kobayashi
2012-07-03 12:44 ` Guennadi Liakhovetski
2012-07-03 13:22 ` Mark Brown
2012-07-03 13:44 ` Guennadi Liakhovetski
2012-07-03 14:45 ` Mark Brown
2012-07-03 15:05 ` Guennadi Liakhovetski
2012-07-03 15:06 ` Mark Brown
2012-07-03 15:35 ` Guennadi Liakhovetski
2012-07-03 19:33 ` Mark Brown
2012-07-04 6:39 ` Guennadi Liakhovetski
2012-07-04 10:38 ` Mark Brown
2012-07-04 10:40 ` Rafael J. Wysocki [this message]
2012-07-04 10:41 ` Magnus Damm
2012-07-04 10:46 ` Paul Mundt
2012-07-04 10:48 ` Mark Brown
2012-07-04 10:51 ` Guennadi Liakhovetski
2012-07-04 10:53 ` Guennadi Liakhovetski
2012-07-04 10:55 ` Rafael J. Wysocki
2012-07-04 10:58 ` Magnus Damm
2012-07-04 11:00 ` Magnus Damm
2012-07-04 11:05 ` Guennadi Liakhovetski
2012-07-04 11:08 ` Guennadi Liakhovetski
2012-07-04 11:22 ` Rafael J. Wysocki
2012-07-04 13:31 ` Magnus Damm
2012-07-04 14:29 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201207041240.56586.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox