From: Paul Mundt <lethal@linux-sh.org>
To: Vinod Koul <vinod.koul@linux.intel.com>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-kernel@vger.kernel.org, Magnus Damm <magnus.damm@gmail.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
linux-sh@vger.kernel.org
Subject: Re: [PATCH 9/9 v3] dma: shdma: convert to the shdma base library
Date: Thu, 26 Jul 2012 06:58:04 +0000 [thread overview]
Message-ID: <20120726065804.GF30468@linux-sh.org> (raw)
In-Reply-To: <1343285361.1726.8980.camel@vkoul-udesk3>
On Thu, Jul 26, 2012 at 12:19:21PM +0530, Vinod Koul wrote:
> On Wed, 2012-07-25 at 12:59 +0900, Paul Mundt wrote:
> > On Wed, May 09, 2012 at 05:09:21PM +0200, Guennadi Liakhovetski wrote:
> > > The shdma base library has originally been extracted from the shdma driver,
> > > which now can be converted to actually use it.
> > >
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > > ---
> > > drivers/dma/sh/shdma.c | 1122 ++++++++++++------------------------------------
> > > drivers/dma/sh/shdma.h | 44 +-
> > > include/linux/sh_dma.h | 33 +-
> > > 3 files changed, 302 insertions(+), 897 deletions(-)
> > >
> > Now that this has hit mainline, the sh-sci with DMA enabled build is
> > broken:
> >
> > CC drivers/tty/serial/sh-sci.o
> > drivers/tty/serial/sh-sci.c: In function 'work_fn_rx':
> > drivers/tty/serial/sh-sci.c:1413:67: error: dereferencing pointer to incomplete type
> > drivers/tty/serial/sh-sci.c:1413:81: warning: type defaults to 'int' in declaration of '__mptr'
> > drivers/tty/serial/sh-sci.c:1413:90: warning: initialization from incompatible pointer type
> > drivers/tty/serial/sh-sci.c:1413:161: error: invalid use of undefined type 'struct sh_desc'
> > drivers/tty/serial/sh-sci.c:1419:83: error: dereferencing pointer to incomplete type
> > drivers/tty/serial/sh-sci.c:1419:101: error: dereferencing pointer to incomplete type
> > drivers/tty/serial/sh-sci.c:1423:42: error: dereferencing pointer to incomplete type
> This was in -next for quite some time :(
>
It seems we don't have any configs that have this default-enabled under
-next, so it wasn't noticed before. Still, as Guennadi wrote this code
I'm surprised it was overlooked.
next prev parent reply other threads:[~2012-07-26 6:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-09 15:09 [PATCH 0/9 v3] extract an shdma base library from shdma.c Guennadi Liakhovetski
2012-05-09 15:09 ` [PATCH 1/9 v3] dmaengine: add an shdma-base library Guennadi Liakhovetski
2012-05-15 4:34 ` Vinod Koul
2012-05-18 8:21 ` Guennadi Liakhovetski
2012-05-25 8:27 ` Vinod Koul
2012-05-25 8:30 ` Guennadi Liakhovetski
2012-06-28 8:52 ` Guennadi Liakhovetski
2012-07-02 20:28 ` Guennadi Liakhovetski
2012-07-02 20:30 ` [PATCH 0.5/9] dma: move shdma driver to an own directory Guennadi Liakhovetski
2012-07-13 3:38 ` [PATCH 1/9 v3] dmaengine: add an shdma-base library Vinod Koul
2012-07-16 6:10 ` Vinod Koul
2012-05-25 10:39 ` Laxman Dewangan
2012-05-25 10:59 ` Guennadi Liakhovetski
2012-05-09 15:09 ` [PATCH 2/9 v3] dma: shdma: prepare for conversion to the shdma base library Guennadi Liakhovetski
2012-05-15 4:35 ` Vinod Koul
2012-05-18 8:21 ` Guennadi Liakhovetski
2012-05-09 15:09 ` [PATCH 3/9 v3] mmc: sh_mmcif: remove unneeded struct sh_mmcif_dma, prepare to shdma conversion Guennadi Liakhovetski
2012-07-05 17:35 ` Chris Ball
2012-05-09 15:09 ` [PATCH 4/9 v3] mmc: sh_mobile_sdhi: prepare for conversion to the shdma base library Guennadi Liakhovetski
2012-07-05 17:37 ` Chris Ball
2012-05-09 15:09 ` [PATCH 5/9 v3] serial: sh-sci: " Guennadi Liakhovetski
2012-05-10 3:09 ` Paul Mundt
2012-05-15 4:39 ` Vinod Koul
2012-05-18 8:21 ` Guennadi Liakhovetski
2012-05-09 15:09 ` [PATCH 6/9 v3] ASoC: siu: " Guennadi Liakhovetski
2012-05-09 15:37 ` Mark Brown
2012-05-09 15:09 ` [PATCH 7/9 v3] usb: renesas_usbhs: " Guennadi Liakhovetski
2012-05-09 23:59 ` kuninori.morimoto.gx
2012-05-10 0:07 ` Greg Kroah-Hartman
2012-05-09 15:09 ` [PATCH 8/9 v3] ASoC: fsi: " Guennadi Liakhovetski
2012-05-09 15:39 ` Mark Brown
2012-05-09 23:59 ` kuninori.morimoto.gx
2012-05-09 15:09 ` [PATCH 9/9 v3] dma: shdma: convert " Guennadi Liakhovetski
2012-07-25 3:59 ` Paul Mundt
2012-07-26 6:53 ` Vinod Koul
2012-07-26 6:58 ` Paul Mundt [this message]
2012-07-26 11:32 ` Vinod Koul
2012-07-26 21:39 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726065804.GF30468@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=vinod.koul@linux.intel.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).