From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Tue, 07 Aug 2012 01:55:51 +0000 Subject: Re: [Regression, post-3.5] System suspend broken on the Mackerel board Message-Id: <20120807015551.GB1614@linux-sh.org> List-Id: References: <20120801073004.GE15380@linux-sh.org> <201208050002.43465.rjw@sisk.pl> In-Reply-To: <201208050002.43465.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "Rafael J. Wysocki" Cc: kuninori.morimoto.gx@renesas.com, Magnus Damm , Linux-sh list , Linux PM list , LKML , Kuninori Morimoto On Sun, Aug 05, 2012 at 12:02:43AM +0200, Rafael J. Wysocki wrote: > On Wednesday, August 01, 2012, Paul Mundt wrote: > > Turns out we can just collapse the probe/init stuff anyways, so this > > ought to fix it. I've verified that it fixes Morimoto-san's issue, my > > expectation is that the mackerel case is likewise getting tripped up but > > no one bothered implementing any error detecting logic for gpio_request() > > failing, so it doesn't fail gracefully. > > > > I'll be pushing this out to Linus shortly: > > Thanks, this helped. Resume works correctly on Mackerel with 3.6-rc1. > > However, I'm now seeing a different problem related to system suspend on that, > board which is that sh7372_enter_a3sm_common() returns immediately, as though > at least one of the wakeup signals was permanently asserted. This hadn't > happened before your last pull request was merged, so I suspect that one > of the irqdomain patches might introduce this behavior. > Ok, I'll back off the irqdomain selection until we have a chance to test it more on the other platforms.