From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: mackerel: fixup usb module order
Date: Fri, 31 Aug 2012 06:33:23 +0000 [thread overview]
Message-ID: <20120831063321.GC7014@verge.net.au> (raw)
In-Reply-To: <87obmoefn2.wl%kuninori.morimoto.gx@renesas.com>
On Mon, Aug 27, 2012 at 05:41:13PM +0900, Simon Horman wrote:
> On Mon, Aug 06, 2012 at 05:19:12PM +0900, Simon Horman wrote:
> > On Sun, Aug 05, 2012 at 10:47:00PM -0700, Kuninori Morimoto wrote:
> > > renesas_usbhs driver can play role as both Host and Gadget.
> > > In case of Gadget, it requires not only renesas_usbhs
> > > but also usb gadget module (like g_ether).
> > > So, renesas_usbhs driver calls usb_add_gadget_udc() on probe time.
> > >
> > > Because of this behavior,
> > > Host port plays also Gadget role if kernel has both Host/Gadget support.
> > >
> > > In mackerel case, from 0ada2da51800a4914887a9bcf22d563be80e50be
> > > (ARM: mach-shmobile: mackerel: use renesas_usbhs instead of r8a66597_hcd)
> > > usb0 plays Gadget role, and usb1 plays Host role,
> > > and current mackerel board probes as usb1 -> usb0.
> > > Thus, 1st installed usb gadget module (like g_ether) will be
> > > assigned to usb1 (= usb Host port), and 2nd module to usb0 (= usb Gadget port).
> > > It is very confusable for user.
> > > This patch fixup usb modes probing order as usb0 -> usb1.
> > >
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Reviewed-by: Simon Horman <horms@verge.net.au>
>
> I have pushed this to the mackerel branch of my renesas tree,
> git://git.kernel.org/pub/scm/linux/kernel/git/horms/renesas.git
>
> I will endeavour to get it included in 3.7.
On further consideration I have moved this patch to the
fixes branch (and removed the now empty mackerel branch).
I will endeavour to get it included in 3.6.
prev parent reply other threads:[~2012-08-31 6:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 5:47 [PATCH] ARM: shmobile: mackerel: fixup usb module order Kuninori Morimoto
2012-08-06 8:19 ` Simon Horman
2012-08-27 8:41 ` Simon Horman
2012-08-31 6:33 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120831063321.GC7014@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).