linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc
Date: Fri, 31 Aug 2012 07:16:06 +0000	[thread overview]
Message-ID: <20120831071606.GE7014@verge.net.au> (raw)
In-Reply-To: <87y5l95bfg.wl%kuninori.morimoto.gx@renesas.com>

Hi Kobayashi-san,

this patch was handled by Rafael and should appear in 3.6-rc3.
Thus, I would rather not add it to my kzm9g breanch.

I have, however, now pulled Rafael's fixes branch into my next branch.
So you should be able to get working kzm9g code there (once kernel.org syncs).

On Fri, Aug 31, 2012 at 03:55:05PM +0900, Tetsuyuki Kobayashi wrote:
> Simon-san,
> 
> Could you apply this patch to kzm9g branch ?
> 
> (2012/08/21 9:35), Kuninori Morimoto wrote:
> >sh73a0 :: intca_irq_pins_desc irq table had conflict
> >from irq 552 to irq 557 before.
> >But the second controller was simply trampling the
> >first one by way of the -EEXIST case from irq_alloc_desc_at().
> >
> >But now, we have irqdomain support from
> >1d6a21b0a672fb29b01ccf397d478e0541e17716
> >(sh: intc: initial irqdomain support)
> >
> >The irqdomain code has simply tightened down the sanity checks and
> >error path. So, sh73a0 CPU board got some WARNING when booting now.
> >This patch fixup RELOC_BASE to solve this issue.
> >
> >Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >---
> >This patch is for paul/sh-latest branch
> >
> >  arch/arm/mach-shmobile/intc-sh73a0.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/arch/arm/mach-shmobile/intc-sh73a0.c b/arch/arm/mach-shmobile/intc-sh73a0.c
> >index ee44740..588555a 100644
> >--- a/arch/arm/mach-shmobile/intc-sh73a0.c
> >+++ b/arch/arm/mach-shmobile/intc-sh73a0.c
> >@@ -259,9 +259,9 @@ static int sh73a0_set_wake(struct irq_data *data, unsigned int on)
> >  	return 0; /* always allow wakeup */
> >  }
> >
> >-#define RELOC_BASE 0x1000
> >+#define RELOC_BASE 0x1200
> >
> >-/* INTCA IRQ pins at INTCS + 0x1000 to make space for GIC+INTC handling */
> >+/* INTCA IRQ pins at INTCS + RELOC_BASE to make space for GIC+INTC handling */
> >  #define INTCS_VECT_RELOC(n, vect) INTCS_VECT((n), (vect) + RELOC_BASE)
> >
> >  INTC_IRQ_PINS_32(intca_irq_pins, 0xe6900000,
> >
> 

      parent reply	other threads:[~2012-08-31  7:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21  0:35 [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc Kuninori Morimoto
2012-08-21  0:54 ` Paul Mundt
2012-08-21  2:48 ` Kuninori Morimoto
2012-08-27  8:30 ` Simon Horman
2012-08-31  6:55 ` Tetsuyuki Kobayashi
2012-08-31  7:16 ` Simon Horman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120831071606.GE7014@verge.net.au \
    --to=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).