[PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins

linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc
@ 2012-08-21  0:35 Kuninori Morimoto
  2012-08-21  0:54 ` Paul Mundt
                   ` (4 more replies)
  0 siblings, 5 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2012-08-21  0:35 UTC (permalink / raw)
  To: linux-sh

sh73a0 :: intca_irq_pins_desc irq table had conflict
from irq 552 to irq 557 before.
But the second controller was simply trampling the
first one by way of the -EEXIST case from irq_alloc_desc_at().

But now, we have irqdomain support from
1d6a21b0a672fb29b01ccf397d478e0541e17716
(sh: intc: initial irqdomain support)

The irqdomain code has simply tightened down the sanity checks and
error path. So, sh73a0 CPU board got some WARNING when booting now.
This patch fixup RELOC_BASE to solve this issue.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
This patch is for paul/sh-latest branch

 arch/arm/mach-shmobile/intc-sh73a0.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-shmobile/intc-sh73a0.c b/arch/arm/mach-shmobile/intc-sh73a0.c
index ee44740..588555a 100644
--- a/arch/arm/mach-shmobile/intc-sh73a0.c
+++ b/arch/arm/mach-shmobile/intc-sh73a0.c
@@ -259,9 +259,9 @@ static int sh73a0_set_wake(struct irq_data *data, unsigned int on)
 	return 0; /* always allow wakeup */
 }
 
-#define RELOC_BASE 0x1000
+#define RELOC_BASE 0x1200
 
-/* INTCA IRQ pins at INTCS + 0x1000 to make space for GIC+INTC handling */
+/* INTCA IRQ pins at INTCS + RELOC_BASE to make space for GIC+INTC handling */
 #define INTCS_VECT_RELOC(n, vect) INTCS_VECT((n), (vect) + RELOC_BASE)
 
 INTC_IRQ_PINS_32(intca_irq_pins, 0xe6900000,
-- 
1.7.5.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc
  2012-08-21  0:35 [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc Kuninori Morimoto
@ 2012-08-21  0:54 ` Paul Mundt
  2012-08-21  2:48 ` Kuninori Morimoto
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Paul Mundt @ 2012-08-21  0:54 UTC (permalink / raw)
  To: linux-sh

On Mon, Aug 20, 2012 at 05:35:52PM -0700, Kuninori Morimoto wrote:
> sh73a0 :: intca_irq_pins_desc irq table had conflict
> from irq 552 to irq 557 before.
> But the second controller was simply trampling the
> first one by way of the -EEXIST case from irq_alloc_desc_at().
> 
> But now, we have irqdomain support from
> 1d6a21b0a672fb29b01ccf397d478e0541e17716
> (sh: intc: initial irqdomain support)
> 
> The irqdomain code has simply tightened down the sanity checks and
> error path. So, sh73a0 CPU board got some WARNING when booting now.
> This patch fixup RELOC_BASE to solve this issue.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> This patch is for paul/sh-latest branch
> 
This can go through Rafael's tree, as nothing here depends on anything I
have outstanding. I have the multi-evt fix pending, but that's about it.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc
  2012-08-21  0:35 [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc Kuninori Morimoto
  2012-08-21  0:54 ` Paul Mundt
@ 2012-08-21  2:48 ` Kuninori Morimoto
  2012-08-27  8:30 ` Simon Horman
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 6+ messages in thread
From: Kuninori Morimoto @ 2012-08-21  2:48 UTC (permalink / raw)
  To: linux-sh


Hi Rafael

This patch is required for v3.6-rcX

> On Mon, Aug 20, 2012 at 05:35:52PM -0700, Kuninori Morimoto wrote:
> > sh73a0 :: intca_irq_pins_desc irq table had conflict
> > from irq 552 to irq 557 before.
> > But the second controller was simply trampling the
> > first one by way of the -EEXIST case from irq_alloc_desc_at().
> > 
> > But now, we have irqdomain support from
> > 1d6a21b0a672fb29b01ccf397d478e0541e17716
> > (sh: intc: initial irqdomain support)
> > 
> > The irqdomain code has simply tightened down the sanity checks and
> > error path. So, sh73a0 CPU board got some WARNING when booting now.
> > This patch fixup RELOC_BASE to solve this issue.
> > 
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > This patch is for paul/sh-latest branch
> > 
> This can go through Rafael's tree, as nothing here depends on anything I
> have outstanding. I have the multi-evt fix pending, but that's about it.

Best regards
---
Kuninori Morimoto

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc
  2012-08-21  0:35 [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc Kuninori Morimoto
  2012-08-21  0:54 ` Paul Mundt
  2012-08-21  2:48 ` Kuninori Morimoto
@ 2012-08-27  8:30 ` Simon Horman
  2012-08-31  6:55 ` Tetsuyuki Kobayashi
  2012-08-31  7:16 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2012-08-27  8:30 UTC (permalink / raw)
  To: linux-sh

On Mon, Aug 20, 2012 at 07:48:40PM -0700, Kuninori Morimoto wrote:
> 
> Hi Rafael
> 
> This patch is required for v3.6-rcX
> 
> > On Mon, Aug 20, 2012 at 05:35:52PM -0700, Kuninori Morimoto wrote:
> > > sh73a0 :: intca_irq_pins_desc irq table had conflict
> > > from irq 552 to irq 557 before.
> > > But the second controller was simply trampling the
> > > first one by way of the -EEXIST case from irq_alloc_desc_at().
> > > 
> > > But now, we have irqdomain support from
> > > 1d6a21b0a672fb29b01ccf397d478e0541e17716
> > > (sh: intc: initial irqdomain support)
> > > 
> > > The irqdomain code has simply tightened down the sanity checks and
> > > error path. So, sh73a0 CPU board got some WARNING when booting now.
> > > This patch fixup RELOC_BASE to solve this issue.
> > > 
> > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > ---
> > > This patch is for paul/sh-latest branch
> > > 
> > This can go through Rafael's tree, as nothing here depends on anything I
> > have outstanding. I have the multi-evt fix pending, but that's about it.
> 
> Best regards

For the record, Rafael sent a pull request "Renesas ARM-based SoC fix for
v3.6" which includes this patch.

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc
  2012-08-21  0:35 [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc Kuninori Morimoto
                   ` (2 preceding siblings ...)
  2012-08-27  8:30 ` Simon Horman
@ 2012-08-31  6:55 ` Tetsuyuki Kobayashi
  2012-08-31  7:16 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Tetsuyuki Kobayashi @ 2012-08-31  6:55 UTC (permalink / raw)
  To: linux-sh

Simon-san,

Could you apply this patch to kzm9g branch ?

(2012/08/21 9:35), Kuninori Morimoto wrote:
> sh73a0 :: intca_irq_pins_desc irq table had conflict
> from irq 552 to irq 557 before.
> But the second controller was simply trampling the
> first one by way of the -EEXIST case from irq_alloc_desc_at().
>
> But now, we have irqdomain support from
> 1d6a21b0a672fb29b01ccf397d478e0541e17716
> (sh: intc: initial irqdomain support)
>
> The irqdomain code has simply tightened down the sanity checks and
> error path. So, sh73a0 CPU board got some WARNING when booting now.
> This patch fixup RELOC_BASE to solve this issue.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> This patch is for paul/sh-latest branch
>
>   arch/arm/mach-shmobile/intc-sh73a0.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/intc-sh73a0.c b/arch/arm/mach-shmobile/intc-sh73a0.c
> index ee44740..588555a 100644
> --- a/arch/arm/mach-shmobile/intc-sh73a0.c
> +++ b/arch/arm/mach-shmobile/intc-sh73a0.c
> @@ -259,9 +259,9 @@ static int sh73a0_set_wake(struct irq_data *data, unsigned int on)
>   	return 0; /* always allow wakeup */
>   }
>
> -#define RELOC_BASE 0x1000
> +#define RELOC_BASE 0x1200
>
> -/* INTCA IRQ pins at INTCS + 0x1000 to make space for GIC+INTC handling */
> +/* INTCA IRQ pins at INTCS + RELOC_BASE to make space for GIC+INTC handling */
>   #define INTCS_VECT_RELOC(n, vect) INTCS_VECT((n), (vect) + RELOC_BASE)
>
>   INTC_IRQ_PINS_32(intca_irq_pins, 0xe6900000,
>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc
  2012-08-21  0:35 [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc Kuninori Morimoto
                   ` (3 preceding siblings ...)
  2012-08-31  6:55 ` Tetsuyuki Kobayashi
@ 2012-08-31  7:16 ` Simon Horman
  4 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2012-08-31  7:16 UTC (permalink / raw)
  To: linux-sh

Hi Kobayashi-san,

this patch was handled by Rafael and should appear in 3.6-rc3.
Thus, I would rather not add it to my kzm9g breanch.

I have, however, now pulled Rafael's fixes branch into my next branch.
So you should be able to get working kzm9g code there (once kernel.org syncs).

On Fri, Aug 31, 2012 at 03:55:05PM +0900, Tetsuyuki Kobayashi wrote:
> Simon-san,
> 
> Could you apply this patch to kzm9g branch ?
> 
> (2012/08/21 9:35), Kuninori Morimoto wrote:
> >sh73a0 :: intca_irq_pins_desc irq table had conflict
> >from irq 552 to irq 557 before.
> >But the second controller was simply trampling the
> >first one by way of the -EEXIST case from irq_alloc_desc_at().
> >
> >But now, we have irqdomain support from
> >1d6a21b0a672fb29b01ccf397d478e0541e17716
> >(sh: intc: initial irqdomain support)
> >
> >The irqdomain code has simply tightened down the sanity checks and
> >error path. So, sh73a0 CPU board got some WARNING when booting now.
> >This patch fixup RELOC_BASE to solve this issue.
> >
> >Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >---
> >This patch is for paul/sh-latest branch
> >
> >  arch/arm/mach-shmobile/intc-sh73a0.c |    4 ++--
> >  1 files changed, 2 insertions(+), 2 deletions(-)
> >
> >diff --git a/arch/arm/mach-shmobile/intc-sh73a0.c b/arch/arm/mach-shmobile/intc-sh73a0.c
> >index ee44740..588555a 100644
> >--- a/arch/arm/mach-shmobile/intc-sh73a0.c
> >+++ b/arch/arm/mach-shmobile/intc-sh73a0.c
> >@@ -259,9 +259,9 @@ static int sh73a0_set_wake(struct irq_data *data, unsigned int on)
> >  	return 0; /* always allow wakeup */
> >  }
> >
> >-#define RELOC_BASE 0x1000
> >+#define RELOC_BASE 0x1200
> >
> >-/* INTCA IRQ pins at INTCS + 0x1000 to make space for GIC+INTC handling */
> >+/* INTCA IRQ pins at INTCS + RELOC_BASE to make space for GIC+INTC handling */
> >  #define INTCS_VECT_RELOC(n, vect) INTCS_VECT((n), (vect) + RELOC_BASE)
> >
> >  INTC_IRQ_PINS_32(intca_irq_pins, 0xe6900000,
> >
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2012-08-31  7:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-08-21  0:35 [PATCH] ARM: shmobile: sh73a0: fixup RELOC_BASE of intca_irq_pins_desc Kuninori Morimoto
2012-08-21  0:54 ` Paul Mundt
2012-08-21  2:48 ` Kuninori Morimoto
2012-08-27  8:30 ` Simon Horman
2012-08-31  6:55 ` Tetsuyuki Kobayashi
2012-08-31  7:16 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).