From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] arm: Add ARM ERRATA 782773 workaround
Date: Thu, 13 Sep 2012 01:00:42 +0000 [thread overview]
Message-ID: <20120913010041.GD7622@verge.net.au> (raw)
In-Reply-To: <5050CD87.4020800@codeaurora.org>
On Wed, Sep 12, 2012 at 10:59:35AM -0700, Stephen Boyd wrote:
> On 09/12/12 00:14, Simon Horman wrote:
> > @@ -1423,6 +1423,15 @@ config ARM_ERRATA_775420
> > deadlock. This workaround puts DSB before executing ISB at the
> > beginning of the abort exception handler.
> >
> > +config ARM_ERRATA_782773
> > + bool "ARM errata: Updating a translation entry might cause an unexpected translation fault"
> > + depends on CPU_V7
> > + help
> > + This option enables the workaround for the 782773 Cortex-A9 (all r0,
> > + ,r2 and r3 revisions) erratum. It might cause MMU exception in case
>
> Seems to be an extra comma here.
Thanks, here is an updated version.
From: Kouei Abe <kouei.abe.cp@rms.renesas.com>
arm: Add ARM ERRATA 782773 workaround
Signed-off-by: Kouei Abe <kouei.abe.cp@rms.renesas.com>
Signed-off-by: Simon Horman <horms@verge.net.au>
---
arch/arm/Kconfig | 9 +++++++++
arch/arm/mm/proc-v7-2level.S | 8 ++++++++
2 files changed, 17 insertions(+)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 74fbdf7..6367fd9 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -1423,6 +1423,15 @@ config ARM_ERRATA_775420
deadlock. This workaround puts DSB before executing ISB at the
beginning of the abort exception handler.
+config ARM_ERRATA_782773
+ bool "ARM errata: Updating a translation entry might cause an unexpected translation fault"
+ depends on CPU_V7
+ help
+ This option enables the workaround for the 782773 Cortex-A9 (all r0,
+ r2 and r3 revisions) erratum. It might cause MMU exception in case
+ page table walk happens just after updating the existing
+ with setting page table in L1 data cache.
+
endmenu
source "arch/arm/common/Kconfig"
diff --git a/arch/arm/mm/proc-v7-2level.S b/arch/arm/mm/proc-v7-2level.S
index fd045e7..9207b9f 100644
--- a/arch/arm/mm/proc-v7-2level.S
+++ b/arch/arm/mm/proc-v7-2level.S
@@ -103,9 +103,17 @@ ENTRY(cpu_v7_set_pte_ext)
tstne r1, #L_PTE_PRESENT
moveq r3, #0
+#ifdef CONFIG_ARM_ERRATA_782773
+ mrs r2, cpsr @ save cpsr
+ cpsid if @ disable interrupts
+ mcr p15, 0, r0, c7, c14, 1 @ clean & invalidate D line
+#endif
ARM( str r3, [r0, #2048]! )
THUMB( add r0, r0, #2048 )
THUMB( str r3, [r0] )
+#ifdef CONFIG_ARM_ERRATA_782773
+ msr cpsr_c, r2 @ load cpsr
+#endif
mcr p15, 0, r0, c7, c10, 1 @ flush_pte
#endif
mov pc, lr
--
1.7.10.4
next prev parent reply other threads:[~2012-09-13 1:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 7:14 [PATCH 0/2] ARM ERRATA 775420 and 782773 workarounds Simon Horman
2012-09-12 7:14 ` [PATCH 1/2] arm: Add ARM ERRATA 775420 workaround Simon Horman
2012-09-20 9:58 ` Catalin Marinas
2012-09-21 1:04 ` Simon Horman
2012-09-21 8:29 ` Catalin Marinas
2012-09-12 7:14 ` [PATCH 2/2] arm: Add ARM ERRATA 782773 workaround Simon Horman
2012-09-12 17:59 ` Stephen Boyd
2012-09-13 1:00 ` Simon Horman [this message]
2012-09-13 17:20 ` Russell King - ARM Linux
2012-09-20 9:32 ` Catalin Marinas
2012-09-20 9:35 ` Catalin Marinas
2012-09-21 1:00 ` Simon Horman
2012-09-28 1:02 ` Simon Horman
2012-09-28 8:38 ` Catalin Marinas
2012-10-03 2:19 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120913010041.GD7622@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).