From: Simon Horman <horms@verge.net.au>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-mmc@vger.kernel.org, Tetsuyuki Kobayashi <koba@kmckk.co.jp>,
yusuke.goda.sx@renesas.com,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Paul Mundt <lethal@linux-sh.org>,
Magnus Damm <magnus.damm@gmail.com>,
linux-sh@vger.kernel.org,
Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>
Subject: Re: [PATCH] ARM: shmobile: fix MMCIF IRQ assignment on kzm9g
Date: Thu, 20 Sep 2012 01:54:10 +0000 [thread overview]
Message-ID: <20120920015410.GD6873@verge.net.au> (raw)
In-Reply-To: <Pine.LNX.4.64.1209192306370.28849@axis700.grange>
On Wed, Sep 19, 2012 at 11:08:52PM +0200, Guennadi Liakhovetski wrote:
> Hi Simon
>
> On Wed, 19 Sep 2012, Simon Horman wrote:
>
> > On Wed, Sep 19, 2012 at 12:52:26AM +0200, Guennadi Liakhovetski wrote:
> > > Error and operation IRQs are swapped in kzm9g platform data, this patch
> > > fixes their order. The only problem this bug causes is the confusing IRQ
> > > count in /proc/interrupts output, otherwise functionality is unaffected,
> > > since the driver doesn't really differentiate between the two IRQs.
> > >
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> >
> > Thanks Guennadi,
> >
> > as it happens I merged a very similar (same?) patch into the
> > fixes branch of my renesas tree yesterday. It has been accepted
> > by the arm-soc people and should appear in 3.6.
>
> Good, just wondering what about ag5evm, it does seem to have the same
> problem. As mentioned before, this is just a "cosmetic" fix, so, up to you
> to decide when and how and if you'd like to fix it.
Good point.
Could you prepare a patch just for ag5evm for me to queue up?
prev parent reply other threads:[~2012-09-20 1:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-18 22:52 [PATCH] ARM: shmobile: fix MMCIF IRQ assignment on kzm9g Guennadi Liakhovetski
2012-09-19 0:14 ` Simon Horman
2012-09-19 21:08 ` Guennadi Liakhovetski
2012-09-20 1:54 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120920015410.GD6873@verge.net.au \
--to=horms@verge.net.au \
--cc=g.liakhovetski@gmx.de \
--cc=koba@kmckk.co.jp \
--cc=kuninori.morimoto.gx@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lethal@linux-sh.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=yusuke.goda.sx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).