linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: g.liakhovetski@gmx.de
Cc: linux-sh@vger.kernel.org, lethal@linux-sh.org, netdev@vger.kernel.org
Subject: Re: [PATCH] net: sh-eth: fix sleeping in atomic context
Date: Tue, 25 Sep 2012 17:08:31 +0000	[thread overview]
Message-ID: <20120925.130831.369798738695859924.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.1209251143210.9446@axis700.grange>

From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Date: Tue, 25 Sep 2012 12:38:59 +0200 (CEST)

> I'm not sure, whether this is the correct fix, i.e., whether this function 
> is guaranteed to be called on a resumed device, but at least this fixes 
> this specific issue in 3.6-rc7, but leaves another BUG open:

Someone added the runtime PM calls for a reason.

I cannot seriously consider your change until you are able to adequately
consider that aspect.

  reply	other threads:[~2012-09-25 17:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 10:38 [PATCH] net: sh-eth: fix sleeping in atomic context Guennadi Liakhovetski
2012-09-25 17:08 ` David Miller [this message]
2012-09-25 17:27   ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120925.130831.369798738695859924.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=g.liakhovetski@gmx.de \
    --cc=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).