* [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig
[not found] <1349195816-2225-1-git-send-email-arnd@arndb.de>
@ 2012-10-02 16:36 ` Arnd Bergmann
2012-10-03 0:37 ` Simon Horman
0 siblings, 1 reply; 10+ messages in thread
From: Arnd Bergmann @ 2012-10-02 16:36 UTC (permalink / raw)
To: linux-arm-kernel
Cc: arm, linux-kernel, Arnd Bergmann, Paul Mundt, Magnus Damm,
linux-sh, Simon Horman
The CONFIG_MEMORY_SIZE value is interpreted as a 32 bit integer, which
makes sense on a system without PAE. I'm assuming 0x10000000 (256 MB)
is the correct size, because that is used on most other shmobile
boards.
Without this patch, building kota2_defconfig results in:
/home/arnd/linux-arm/arch/arm/kernel/setup.c:790:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-sh@vger.kernel.org
Cc: Simon Horman <horms@verge.net.au>
---
arch/arm/configs/kota2_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/kota2_defconfig b/arch/arm/configs/kota2_defconfig
index b7735d6..0ea4c90 100644
--- a/arch/arm/configs/kota2_defconfig
+++ b/arch/arm/configs/kota2_defconfig
@@ -21,7 +21,7 @@ CONFIG_ARCH_SHMOBILE=y
CONFIG_KEYBOARD_GPIO_POLLED=y
CONFIG_ARCH_SH73A0=y
CONFIG_MACH_KOTA2=y
-CONFIG_MEMORY_SIZE=0x1e0000000
+CONFIG_MEMORY_SIZE=0x10000000
# CONFIG_SH_TIMER_TMU is not set
# CONFIG_SWP_EMULATE is not set
CONFIG_CPU_BPREDICT_DISABLE=y
--
1.7.10
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig
2012-10-02 16:36 ` [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig Arnd Bergmann
@ 2012-10-03 0:37 ` Simon Horman
2012-10-04 8:34 ` Arnd Bergmann
0 siblings, 1 reply; 10+ messages in thread
From: Simon Horman @ 2012-10-03 0:37 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, arm, linux-kernel, Paul Mundt, Magnus Damm,
linux-sh
On Tue, Oct 02, 2012 at 06:36:40PM +0200, Arnd Bergmann wrote:
> The CONFIG_MEMORY_SIZE value is interpreted as a 32 bit integer, which
> makes sense on a system without PAE. I'm assuming 0x10000000 (256 MB)
> is the correct size, because that is used on most other shmobile
> boards.
>
> Without this patch, building kota2_defconfig results in:
Hi Arnd,
I looked through my fines and found a config that I believe
worked with a derivative of 2.6.35.7.
It has CONFIG_MEMORY_SIZE=0x1e800000.
So what I suspect has happened is that an extra zero has crept into
arch/arm/configs/kota2_defconfig and the intended value is:
CONFIG_MEMORY_SIZE=0x1e000000
Unfortunately I do not have access to a board to test this,
nor am I aware of anyone who does.
> /home/arnd/linux-arm/arch/arm/kernel/setup.c:790:2: warning: large integer implicitly truncated to unsigned type [-Woverflow]
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: Magnus Damm <magnus.damm@gmail.com>
> Cc: linux-sh@vger.kernel.org
> Cc: Simon Horman <horms@verge.net.au>
> ---
> arch/arm/configs/kota2_defconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/configs/kota2_defconfig b/arch/arm/configs/kota2_defconfig
> index b7735d6..0ea4c90 100644
> --- a/arch/arm/configs/kota2_defconfig
> +++ b/arch/arm/configs/kota2_defconfig
> @@ -21,7 +21,7 @@ CONFIG_ARCH_SHMOBILE=y
> CONFIG_KEYBOARD_GPIO_POLLED=y
> CONFIG_ARCH_SH73A0=y
> CONFIG_MACH_KOTA2=y
> -CONFIG_MEMORY_SIZE=0x1e0000000
> +CONFIG_MEMORY_SIZE=0x10000000
> # CONFIG_SH_TIMER_TMU is not set
> # CONFIG_SWP_EMULATE is not set
> CONFIG_CPU_BPREDICT_DISABLE=y
> --
> 1.7.10
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig
2012-10-03 0:37 ` Simon Horman
@ 2012-10-04 8:34 ` Arnd Bergmann
2012-10-04 8:58 ` Simon Horman
0 siblings, 1 reply; 10+ messages in thread
From: Arnd Bergmann @ 2012-10-04 8:34 UTC (permalink / raw)
To: Simon Horman
Cc: linux-arm-kernel, arm, linux-kernel, Paul Mundt, Magnus Damm,
linux-sh
On Wednesday 03 October 2012, Simon Horman wrote:
> I looked through my fines and found a config that I believe
> worked with a derivative of 2.6.35.7.
>
> It has CONFIG_MEMORY_SIZE=0x1e800000.
>
> So what I suspect has happened is that an extra zero has crept into
> arch/arm/configs/kota2_defconfig and the intended value is:
>
> CONFIG_MEMORY_SIZE=0x1e000000
>
> Unfortunately I do not have access to a board to test this,
> nor am I aware of anyone who does.
Ok, I'll drop this patch for now then, so we keep the warning around
to remind us of the problem.
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig
2012-10-04 8:34 ` Arnd Bergmann
@ 2012-10-04 8:58 ` Simon Horman
2012-11-30 22:10 ` Olof Johansson
0 siblings, 1 reply; 10+ messages in thread
From: Simon Horman @ 2012-10-04 8:58 UTC (permalink / raw)
To: Arnd Bergmann
Cc: linux-arm-kernel, arm, linux-kernel, Paul Mundt, Magnus Damm,
linux-sh
On Thu, Oct 04, 2012 at 08:34:54AM +0000, Arnd Bergmann wrote:
> On Wednesday 03 October 2012, Simon Horman wrote:
> > I looked through my fines and found a config that I believe
> > worked with a derivative of 2.6.35.7.
> >
> > It has CONFIG_MEMORY_SIZE=0x1e800000.
> >
> > So what I suspect has happened is that an extra zero has crept into
> > arch/arm/configs/kota2_defconfig and the intended value is:
> >
> > CONFIG_MEMORY_SIZE=0x1e000000
> >
> > Unfortunately I do not have access to a board to test this,
> > nor am I aware of anyone who does.
>
> Ok, I'll drop this patch for now then, so we keep the warning around
> to remind us of the problem.
Thanks. I have subsequently located a Kota2 board,
however it may be a little while before I get my hands on it.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig
2012-10-04 8:58 ` Simon Horman
@ 2012-11-30 22:10 ` Olof Johansson
2012-12-01 0:26 ` Simon Horman
2013-01-07 1:59 ` Simon Horman
0 siblings, 2 replies; 10+ messages in thread
From: Olof Johansson @ 2012-11-30 22:10 UTC (permalink / raw)
To: Simon Horman
Cc: Arnd Bergmann, linux-arm-kernel, arm, linux-kernel, Paul Mundt,
Magnus Damm, linux-sh
Hi,
On Thu, Oct 4, 2012 at 1:58 AM, Simon Horman <horms@verge.net.au> wrote:
> On Thu, Oct 04, 2012 at 08:34:54AM +0000, Arnd Bergmann wrote:
>> On Wednesday 03 October 2012, Simon Horman wrote:
>> > I looked through my fines and found a config that I believe
>> > worked with a derivative of 2.6.35.7.
>> >
>> > It has CONFIG_MEMORY_SIZE=0x1e800000.
>> >
>> > So what I suspect has happened is that an extra zero has crept into
>> > arch/arm/configs/kota2_defconfig and the intended value is:
>> >
>> > CONFIG_MEMORY_SIZE=0x1e000000
>> >
>> > Unfortunately I do not have access to a board to test this,
>> > nor am I aware of anyone who does.
>>
>> Ok, I'll drop this patch for now then, so we keep the warning around
>> to remind us of the problem.
>
> Thanks. I have subsequently located a Kota2 board,
> however it may be a little while before I get my hands on it.
Gentle ping. I just came across this warning again so I figured I'd check.
-Olof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig
2012-11-30 22:10 ` Olof Johansson
@ 2012-12-01 0:26 ` Simon Horman
2013-01-07 1:59 ` Simon Horman
1 sibling, 0 replies; 10+ messages in thread
From: Simon Horman @ 2012-12-01 0:26 UTC (permalink / raw)
To: Olof Johansson
Cc: Arnd Bergmann, linux-arm-kernel, arm, linux-kernel, Paul Mundt,
Magnus Damm, linux-sh
On Fri, Nov 30, 2012 at 02:10:47PM -0800, Olof Johansson wrote:
> Hi,
>
> On Thu, Oct 4, 2012 at 1:58 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Oct 04, 2012 at 08:34:54AM +0000, Arnd Bergmann wrote:
> >> On Wednesday 03 October 2012, Simon Horman wrote:
> >> > I looked through my fines and found a config that I believe
> >> > worked with a derivative of 2.6.35.7.
> >> >
> >> > It has CONFIG_MEMORY_SIZE=0x1e800000.
> >> >
> >> > So what I suspect has happened is that an extra zero has crept into
> >> > arch/arm/configs/kota2_defconfig and the intended value is:
> >> >
> >> > CONFIG_MEMORY_SIZE=0x1e000000
> >> >
> >> > Unfortunately I do not have access to a board to test this,
> >> > nor am I aware of anyone who does.
> >>
> >> Ok, I'll drop this patch for now then, so we keep the warning around
> >> to remind us of the problem.
> >
> > Thanks. I have subsequently located a Kota2 board,
> > however it may be a little while before I get my hands on it.
>
> Gentle ping. I just came across this warning again so I figured I'd check.
Sorry, I still don't have a kota2 board.
However, I expect to obtain one within the next week.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig
2012-11-30 22:10 ` Olof Johansson
2012-12-01 0:26 ` Simon Horman
@ 2013-01-07 1:59 ` Simon Horman
2013-01-07 13:33 ` Arnd Bergmann
1 sibling, 1 reply; 10+ messages in thread
From: Simon Horman @ 2013-01-07 1:59 UTC (permalink / raw)
To: Olof Johansson
Cc: Arnd Bergmann, linux-arm-kernel, arm, linux-kernel, Paul Mundt,
Magnus Damm, linux-sh
On Fri, Nov 30, 2012 at 02:10:47PM -0800, Olof Johansson wrote:
> Hi,
>
> On Thu, Oct 4, 2012 at 1:58 AM, Simon Horman <horms@verge.net.au> wrote:
> > On Thu, Oct 04, 2012 at 08:34:54AM +0000, Arnd Bergmann wrote:
> >> On Wednesday 03 October 2012, Simon Horman wrote:
> >> > I looked through my fines and found a config that I believe
> >> > worked with a derivative of 2.6.35.7.
> >> >
> >> > It has CONFIG_MEMORY_SIZE=0x1e800000.
> >> >
> >> > So what I suspect has happened is that an extra zero has crept into
> >> > arch/arm/configs/kota2_defconfig and the intended value is:
> >> >
> >> > CONFIG_MEMORY_SIZE=0x1e000000
> >> >
> >> > Unfortunately I do not have access to a board to test this,
> >> > nor am I aware of anyone who does.
> >>
> >> Ok, I'll drop this patch for now then, so we keep the warning around
> >> to remind us of the problem.
> >
> > Thanks. I have subsequently located a Kota2 board,
> > however it may be a little while before I get my hands on it.
>
> Gentle ping. I just came across this warning again so I figured I'd check.
Hi,
I have my kota2 board up and running now and I believe that
the correct value is 0x1e000000. I will apply a patch to my
defconfigs branch accordingly.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig
2013-01-07 1:59 ` Simon Horman
@ 2013-01-07 13:33 ` Arnd Bergmann
2013-01-08 0:19 ` Simon Horman
0 siblings, 1 reply; 10+ messages in thread
From: Arnd Bergmann @ 2013-01-07 13:33 UTC (permalink / raw)
To: Simon Horman
Cc: Olof Johansson, linux-arm-kernel, arm, linux-kernel, Paul Mundt,
Magnus Damm, linux-sh
On Monday 07 January 2013, Simon Horman wrote:
> I have my kota2 board up and running now and I believe that
> the correct value is 0x1e000000. I will apply a patch to my
> defconfigs branch accordingly.
Ok, thanks!
Should we mark that patch for stable backports?
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig
2013-01-07 13:33 ` Arnd Bergmann
@ 2013-01-08 0:19 ` Simon Horman
2013-01-08 19:06 ` Arnd Bergmann
0 siblings, 1 reply; 10+ messages in thread
From: Simon Horman @ 2013-01-08 0:19 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Olof Johansson, linux-arm-kernel, arm, linux-kernel, Paul Mundt,
Magnus Damm, linux-sh
On Mon, Jan 07, 2013 at 01:33:56PM +0000, Arnd Bergmann wrote:
> On Monday 07 January 2013, Simon Horman wrote:
> > I have my kota2 board up and running now and I believe that
> > the correct value is 0x1e000000. I will apply a patch to my
> > defconfigs branch accordingly.
>
> Ok, thanks!
>
> Should we mark that patch for stable backports?
I don't believe it warrants a stable backport as
the board appears to function well without the change.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig
2013-01-08 0:19 ` Simon Horman
@ 2013-01-08 19:06 ` Arnd Bergmann
0 siblings, 0 replies; 10+ messages in thread
From: Arnd Bergmann @ 2013-01-08 19:06 UTC (permalink / raw)
To: Simon Horman
Cc: Olof Johansson, linux-arm-kernel, arm, linux-kernel, Paul Mundt,
Magnus Damm, linux-sh
On Tuesday 08 January 2013, Simon Horman wrote:
> >
> > Should we mark that patch for stable backports?
>
> I don't believe it warrants a stable backport as
> the board appears to function well without the change.
Ok, fair enough. I was thinking of getting rid of the build warning in the older
kernel, but it's probably not worth it if there is no functional impact.
Arnd
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2013-01-08 19:06 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1349195816-2225-1-git-send-email-arnd@arndb.de>
2012-10-02 16:36 ` [PATCH 01/17] ARM: shmobile: fix memory size for kota2_defconfig Arnd Bergmann
2012-10-03 0:37 ` Simon Horman
2012-10-04 8:34 ` Arnd Bergmann
2012-10-04 8:58 ` Simon Horman
2012-11-30 22:10 ` Olof Johansson
2012-12-01 0:26 ` Simon Horman
2013-01-07 1:59 ` Simon Horman
2013-01-07 13:33 ` Arnd Bergmann
2013-01-08 0:19 ` Simon Horman
2013-01-08 19:06 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).