* __raw_xxx() :: compile warning on sh-arm
@ 2012-10-15 2:08 Kuninori Morimoto
2012-10-15 5:13 ` Paul Mundt
0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2012-10-15 2:08 UTC (permalink / raw)
To: linux-sh
Hi Paul, Simon, Magnus
Current linus/master tree has compile warning on __raw_xxx() if it was "sh-arm" kernel.
It doesn't happen on "sh" kernel.
I guess it from
195bbcac2e5c12f7fb99cdcc492c3000c5537f4a
(ARM: 7500/1: io: avoid writeback addressing modes for __raw_ accessors)
---- ${LINUX}/drivers/sh/intc/chip.c ---------------
${LINUX}/drivers/sh/intc/chip.c: In function 'intc_mask_ack':
${LINUX}/drivers/sh/intc/chip.c:99:4: warning: passing argument 1 of '__raw_readb' makes pointer from integer without a cast [enabled by default]
In file included from ${LINUX}/include/linux/io.h:22:0,
from ${LINUX}/drivers/sh/intc/chip.c:13:
${LINUX}/arch/arm/include/asm/io.h:95:18: note: expected 'const volatile void *' but argument is of type 'long unsigned int'
${LINUX}/drivers/sh/intc/chip.c:100:4: warning: passing argument 2 of '__raw_writeb' makes pointer from integer without a cast [enabled by default]
In file included from ${LINUX}/include/linux/io.h:22:0,
from ${LINUX}/drivers/sh/intc/chip.c:13:
${LINUX}/arch/arm/include/asm/io.h:81:20: note: expected 'volatile void *' but argument is of type 'long unsigned int'
${LINUX}/drivers/sh/intc/chip.c:103:4: warning: passing argument 1 of '__raw_readw' makes pointer from integer without a cast [enabled by default]
In file included from ${LINUX}/include/linux/io.h:22:0,
from ${LINUX}/drivers/sh/intc/chip.c:13:
${LINUX}/arch/arm/include/asm/io.h:71:19: note: expected 'const volatile void *' but argument is of type 'long unsigned int'
${LINUX}/drivers/sh/intc/chip.c:104:4: warning: passing argument 2 of '__raw_writew' makes pointer from integer without a cast [enabled by default]
In file included from ${LINUX}/include/linux/io.h:22:0,
....
----- ${LINUX}/drivers/tty/serial/sh-sci.c -----------
${LINUX}/drivers/tty/serial/sh-sci.c:533:2: warning: passing argument 1 of '__raw_readb' makes pointer from integer without a cast [enabled by default]
In file included from ${LINUX}/include/linux/scatterlist.h:10:0,
from ${LINUX}/include/linux/dmaengine.h:27,
from ${LINUX}/include/linux/sh_dma.h:13,
from ${LINUX}/drivers/tty/serial/sh-sci.c:28:
${LINUX}/arch/arm/include/asm/io.h:95:18: note: expected 'const volatile void *' but argument is of type 'int'
Best regards
---
Kuninori Morimoto
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: __raw_xxx() :: compile warning on sh-arm
2012-10-15 2:08 __raw_xxx() :: compile warning on sh-arm Kuninori Morimoto
@ 2012-10-15 5:13 ` Paul Mundt
0 siblings, 0 replies; 2+ messages in thread
From: Paul Mundt @ 2012-10-15 5:13 UTC (permalink / raw)
To: linux-sh
On Sun, Oct 14, 2012 at 07:08:55PM -0700, Kuninori Morimoto wrote:
>
> Hi Paul, Simon, Magnus
>
> Current linus/master tree has compile warning on __raw_xxx() if it was "sh-arm" kernel.
> It doesn't happen on "sh" kernel.
>
> I guess it from
> 195bbcac2e5c12f7fb99cdcc492c3000c5537f4a
> (ARM: 7500/1: io: avoid writeback addressing modes for __raw_ accessors)
>
Yes, unsurprisingly this is what happens when you are told how to fix
something properly and then simply drop that part of your patch rather
than doing the bare minimum in classic ARM style.
It's fixed in my tree now via:
sh: Fix up more fallout from pointless ARM __iomem churn.
I'll send it off to Linus.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-15 5:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-15 2:08 __raw_xxx() :: compile warning on sh-arm Kuninori Morimoto
2012-10-15 5:13 ` Paul Mundt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).