From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource
Date: Wed, 14 Nov 2012 23:22:49 +0000 [thread overview]
Message-ID: <20121114232249.GN15960@verge.net.au> (raw)
In-Reply-To: <1352803609-16669-1-git-send-email-hechtb@gmail.com>
On Tue, Nov 13, 2012 at 11:46:49AM +0100, Bastian Hecht wrote:
> The FLCTL driver now requires the resource of the error IRQ.
Hi Bastian,
could you provide a little more information on:
* Why this is so. Is it related to a change in another commit?
* What the implications are of this change not being applied:
the driver doesn't work?
> Signed-off-by: Bastian Hecht <hechtb@gmail.com>
> ---
> arch/arm/mach-shmobile/board-mackerel.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 0c27c81..66ec616 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -1018,7 +1018,11 @@ static struct resource nand_flash_resources[] = {
> .start = 0xe6a30000,
> .end = 0xe6a3009b,
> .flags = IORESOURCE_MEM,
> - }
> + },
> + [1] = {
> + .start = evt2irq(0x0d80), /* flstei: status error irq */
> + .flags = IORESOURCE_IRQ,
> + },
> };
>
> static struct sh_flctl_platform_data nand_flash_data = {
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2012-11-14 23:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 10:46 [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Bastian Hecht
2012-11-14 23:22 ` Simon Horman [this message]
2012-11-15 9:13 ` Bastian Hecht
2012-11-16 0:02 ` Simon Horman
2012-11-20 0:05 ` Bastian Hecht
2012-11-20 0:43 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2012-11-19 1:24 [GIT PULL] Renesas ARM-based SoC boards for v3.8 #3 Simon Horman
2012-11-19 1:24 ` [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Simon Horman
2012-11-19 12:30 ` Sergei Shtylyov
2012-11-20 0:03 ` Simon Horman
2012-11-20 0:43 [GIT PULL v2] Renesas ARM-based SoC boards for v3.8 #3 Simon Horman
2012-11-20 0:43 ` [PATCH] ARM: shmobile: mackerel: Add FLCTL IRQ resource Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121114232249.GN15960@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).