* [PATCH] mmc: sh_mobile_sdhi: fix clock frequency printing
@ 2012-11-28 9:24 Guennadi Liakhovetski
2012-11-30 9:02 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Guennadi Liakhovetski @ 2012-11-28 9:24 UTC (permalink / raw)
To: linux-mmc; +Cc: linux-sh, Chris Ball
During its probing the SDHI driver prints out the clock frequency, but
does it wrongly, always reporting 0Hz. Use the MMC host frequency value
to fix this issue.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
drivers/mmc/host/sh_mobile_sdhi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
index 22ac8e7..d6ff853 100644
--- a/drivers/mmc/host/sh_mobile_sdhi.c
+++ b/drivers/mmc/host/sh_mobile_sdhi.c
@@ -248,7 +248,7 @@ static int __devinit sh_mobile_sdhi_probe(struct platform_device *pdev)
dev_info(&pdev->dev, "%s base at 0x%08lx clock rate %u MHz\n",
mmc_hostname(host->mmc), (unsigned long)
(platform_get_resource(pdev, IORESOURCE_MEM, 0)->start),
- mmc_data->hclk / 1000000);
+ host->mmc->f_max / 1000000);
return ret;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sh_mobile_sdhi: fix clock frequency printing
2012-11-28 9:24 [PATCH] mmc: sh_mobile_sdhi: fix clock frequency printing Guennadi Liakhovetski
@ 2012-11-30 9:02 ` Simon Horman
2012-12-03 19:21 ` Chris Ball
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2012-11-30 9:02 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: linux-mmc, linux-sh, Chris Ball
On Wed, Nov 28, 2012 at 10:24:13AM +0100, Guennadi Liakhovetski wrote:
> During its probing the SDHI driver prints out the clock frequency, but
> does it wrongly, always reporting 0Hz. Use the MMC host frequency value
> to fix this issue.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/mmc/host/sh_mobile_sdhi.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mmc/host/sh_mobile_sdhi.c b/drivers/mmc/host/sh_mobile_sdhi.c
> index 22ac8e7..d6ff853 100644
> --- a/drivers/mmc/host/sh_mobile_sdhi.c
> +++ b/drivers/mmc/host/sh_mobile_sdhi.c
> @@ -248,7 +248,7 @@ static int __devinit sh_mobile_sdhi_probe(struct platform_device *pdev)
> dev_info(&pdev->dev, "%s base at 0x%08lx clock rate %u MHz\n",
> mmc_hostname(host->mmc), (unsigned long)
> (platform_get_resource(pdev, IORESOURCE_MEM, 0)->start),
> - mmc_data->hclk / 1000000);
> + host->mmc->f_max / 1000000);
>
> return ret;
>
> --
> 1.7.2.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mmc: sh_mobile_sdhi: fix clock frequency printing
2012-11-30 9:02 ` Simon Horman
@ 2012-12-03 19:21 ` Chris Ball
0 siblings, 0 replies; 3+ messages in thread
From: Chris Ball @ 2012-12-03 19:21 UTC (permalink / raw)
To: Simon Horman; +Cc: Guennadi Liakhovetski, linux-mmc, linux-sh
Hi,
On Fri, Nov 30 2012, Simon Horman wrote:
> On Wed, Nov 28, 2012 at 10:24:13AM +0100, Guennadi Liakhovetski wrote:
>> During its probing the SDHI driver prints out the clock frequency, but
>> does it wrongly, always reporting 0Hz. Use the MMC host frequency value
>> to fix this issue.
>>
>> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Thanks, pushed to mmc-next for 3.8.
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-03 19:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-28 9:24 [PATCH] mmc: sh_mobile_sdhi: fix clock frequency printing Guennadi Liakhovetski
2012-11-30 9:02 ` Simon Horman
2012-12-03 19:21 ` Chris Ball
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).