* [PATCH] ARM: shmobile: r8a7779: Fix GPIO input reg addresses
@ 2012-12-11 9:48 Phil Edworthy
2012-12-11 10:56 ` Laurent Pinchart
0 siblings, 1 reply; 6+ messages in thread
From: Phil Edworthy @ 2012-12-11 9:48 UTC (permalink / raw)
To: linux-arm-kernel
The INDTx register addresses were wrong.
---
arch/arm/mach-shmobile/pfc-r8a7779.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c b/arch/arm/mach-shmobile/pfc-r8a7779.c
index 15f6a48..717e058 100644
--- a/arch/arm/mach-shmobile/pfc-r8a7779.c
+++ b/arch/arm/mach-shmobile/pfc-r8a7779.c
@@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
};
static struct pinmux_data_reg pinmux_data_regs[] = {
- { PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } },
- { PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } },
- { PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } },
- { PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } },
- { PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } },
- { PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } },
- { PINMUX_DATA_REG("INDT6", 0xffc46008, 32) {
+ { PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } },
+ { PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } },
+ { PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } },
+ { PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } },
+ { PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } },
+ { PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } },
+ { PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) {
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA,
GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: shmobile: r8a7779: Fix GPIO input reg addresses
2012-12-11 9:48 [PATCH] ARM: shmobile: r8a7779: Fix GPIO input reg addresses Phil Edworthy
@ 2012-12-11 10:56 ` Laurent Pinchart
2012-12-11 11:34 ` [PATCH v2] " Phil Edworthy
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2012-12-11 10:56 UTC (permalink / raw)
To: linux-arm-kernel
Hi Phil,
Thank you for the patch.
Your SoB line is missing, have you forgotten to commit with -s ?
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
On Tuesday 11 December 2012 09:48:15 Phil Edworthy wrote:
> The INDTx register addresses were wrong.
> ---
> arch/arm/mach-shmobile/pfc-r8a7779.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c
> b/arch/arm/mach-shmobile/pfc-r8a7779.c index 15f6a48..717e058 100644
> --- a/arch/arm/mach-shmobile/pfc-r8a7779.c
> +++ b/arch/arm/mach-shmobile/pfc-r8a7779.c
> @@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] > { };
>
> static struct pinmux_data_reg pinmux_data_regs[] = {
> - { PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } },
> - { PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } },
> - { PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } },
> - { PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } },
> - { PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } },
> - { PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } },
> - { PINMUX_DATA_REG("INDT6", 0xffc46008, 32) {
> + { PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } },
> + { PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } },
> + { PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } },
> + { PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } },
> + { PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } },
> + { PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } },
> + { PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) {
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA,
> GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg addresses
2012-12-11 10:56 ` Laurent Pinchart
@ 2012-12-11 11:34 ` Phil Edworthy
2012-12-11 11:40 ` Laurent Pinchart
0 siblings, 1 reply; 6+ messages in thread
From: Phil Edworthy @ 2012-12-11 11:34 UTC (permalink / raw)
To: linux-arm-kernel
The INDTx register addresses were wrong.
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
---
v2:
Included SoB line this time - doh!
arch/arm/mach-shmobile/pfc-r8a7779.c | 14 +++++++-------
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c b/arch/arm/mach-shmobile/pfc-r8a7779.c
index 15f6a48..717e058 100644
--- a/arch/arm/mach-shmobile/pfc-r8a7779.c
+++ b/arch/arm/mach-shmobile/pfc-r8a7779.c
@@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] = {
};
static struct pinmux_data_reg pinmux_data_regs[] = {
- { PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } },
- { PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } },
- { PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } },
- { PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } },
- { PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } },
- { PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } },
- { PINMUX_DATA_REG("INDT6", 0xffc46008, 32) {
+ { PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } },
+ { PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } },
+ { PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } },
+ { PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } },
+ { PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } },
+ { PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } },
+ { PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) {
0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA,
GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
--
1.7.5.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg addresses
2012-12-11 11:34 ` [PATCH v2] " Phil Edworthy
@ 2012-12-11 11:40 ` Laurent Pinchart
2012-12-12 10:12 ` phil.edworthy
0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2012-12-11 11:40 UTC (permalink / raw)
To: linux-arm-kernel
On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote:
> The INDTx register addresses were wrong.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
You can add
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
:-)
> ---
> v2:
> Included SoB line this time - doh!
>
> arch/arm/mach-shmobile/pfc-r8a7779.c | 14 +++++++-------
> 1 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm/mach-shmobile/pfc-r8a7779.c
> b/arch/arm/mach-shmobile/pfc-r8a7779.c index 15f6a48..717e058 100644
> --- a/arch/arm/mach-shmobile/pfc-r8a7779.c
> +++ b/arch/arm/mach-shmobile/pfc-r8a7779.c
> @@ -2585,13 +2585,13 @@ static struct pinmux_cfg_reg pinmux_config_regs[] > { };
>
> static struct pinmux_data_reg pinmux_data_regs[] = {
> - { PINMUX_DATA_REG("INDT0", 0xffc40008, 32) { GP_INDT(0) } },
> - { PINMUX_DATA_REG("INDT1", 0xffc41008, 32) { GP_INDT(1) } },
> - { PINMUX_DATA_REG("INDT2", 0xffc42008, 32) { GP_INDT(2) } },
> - { PINMUX_DATA_REG("INDT3", 0xffc43008, 32) { GP_INDT(3) } },
> - { PINMUX_DATA_REG("INDT4", 0xffc44008, 32) { GP_INDT(4) } },
> - { PINMUX_DATA_REG("INDT5", 0xffc45008, 32) { GP_INDT(5) } },
> - { PINMUX_DATA_REG("INDT6", 0xffc46008, 32) {
> + { PINMUX_DATA_REG("INDT0", 0xffc4000c, 32) { GP_INDT(0) } },
> + { PINMUX_DATA_REG("INDT1", 0xffc4100c, 32) { GP_INDT(1) } },
> + { PINMUX_DATA_REG("INDT2", 0xffc4200c, 32) { GP_INDT(2) } },
> + { PINMUX_DATA_REG("INDT3", 0xffc4300c, 32) { GP_INDT(3) } },
> + { PINMUX_DATA_REG("INDT4", 0xffc4400c, 32) { GP_INDT(4) } },
> + { PINMUX_DATA_REG("INDT5", 0xffc4500c, 32) { GP_INDT(5) } },
> + { PINMUX_DATA_REG("INDT6", 0xffc4600c, 32) {
> 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> 0, 0, 0, 0, 0, 0, 0, GP_6_8_DATA,
> GP_6_7_DATA, GP_6_6_DATA, GP_6_5_DATA, GP_6_4_DATA,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg addresses
2012-12-11 11:40 ` Laurent Pinchart
@ 2012-12-12 10:12 ` phil.edworthy
2012-12-13 0:33 ` Simon Horman
0 siblings, 1 reply; 6+ messages in thread
From: phil.edworthy @ 2012-12-12 10:12 UTC (permalink / raw)
To: linux-arm-kernel
Hi Simon, Laurent,
(resend as plain text)
> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> To: Phil Edworthy <phil.edworthy@renesas.com>,
> Cc: Simon <horms@verge.net.au>, linux-sh@vger.kernel.org, linux-arm-
> kernel@lists.infradead.org, Magnus <magnus.damm@gmail.com>, Laurent
> Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Date: 11/12/2012 11:39
> Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg
addresses
>
> On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote:
> > The INDTx register addresses were wrong.
> >
> > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
>
> You can add
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Please scrap this patch. I just found out that it screws up the GPIO
outputs. The current code assumes the same register is used for both input
and output, which is not the case. It needs a bit of work to fix this.
Thanks
Phil
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg addresses
2012-12-12 10:12 ` phil.edworthy
@ 2012-12-13 0:33 ` Simon Horman
0 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2012-12-13 0:33 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Dec 12, 2012 at 10:12:27AM +0000, phil.edworthy@renesas.com wrote:
> Hi Simon, Laurent,
>
> (resend as plain text)
>
> > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > To: Phil Edworthy <phil.edworthy@renesas.com>,
> > Cc: Simon <horms@verge.net.au>, linux-sh@vger.kernel.org, linux-arm-
> > kernel@lists.infradead.org, Magnus <magnus.damm@gmail.com>, Laurent
> > Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Date: 11/12/2012 11:39
> > Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg
> addresses
> >
> > On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote:
> > > The INDTx register addresses were wrong.
> > >
> > > Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
> >
> > You can add
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Please scrap this patch. I just found out that it screws up the GPIO
> outputs. The current code assumes the same register is used for both input
> and output, which is not the case. It needs a bit of work to fix this.
Thanks, I have marked v1 and v2 as Rejected in patchwork.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-12-13 0:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-11 9:48 [PATCH] ARM: shmobile: r8a7779: Fix GPIO input reg addresses Phil Edworthy
2012-12-11 10:56 ` Laurent Pinchart
2012-12-11 11:34 ` [PATCH v2] " Phil Edworthy
2012-12-11 11:40 ` Laurent Pinchart
2012-12-12 10:12 ` phil.edworthy
2012-12-13 0:33 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).