From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Thu, 13 Dec 2012 00:33:50 +0000 Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg addresses Message-Id: <20121213003350.GG13343@verge.net.au> List-Id: References: <16942826.W5hEBZUpzF@avalon> <1355225657-18731-1-git-send-email-phil.edworthy@renesas.com> <2861660.bMP77HcQxX@avalon> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Wed, Dec 12, 2012 at 10:12:27AM +0000, phil.edworthy@renesas.com wrote: > Hi Simon, Laurent, > > (resend as plain text) > > > From: Laurent Pinchart > > To: Phil Edworthy , > > Cc: Simon , linux-sh@vger.kernel.org, linux-arm- > > kernel@lists.infradead.org, Magnus , Laurent > > Pinchart > > Date: 11/12/2012 11:39 > > Subject: Re: [PATCH v2] ARM: shmobile: r8a7779: Fix GPIO input reg > addresses > > > > On Tuesday 11 December 2012 11:34:17 Phil Edworthy wrote: > > > The INDTx register addresses were wrong. > > > > > > Signed-off-by: Phil Edworthy > > > > You can add > > > > Acked-by: Laurent Pinchart > > Please scrap this patch. I just found out that it screws up the GPIO > outputs. The current code assumes the same register is used for both input > and output, which is not the case. It needs a bit of work to fix this. Thanks, I have marked v1 and v2 as Rejected in patchwork.