From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Fri, 14 Dec 2012 13:47:19 +0000 Subject: Re: [PATCH 1/2] ARM: SH-Mobile: sh73a0: Secondary CPUs handle own SCU flags Message-Id: <20121214134719.GK16382@verge.net.au> List-Id: References: <1354795719-5578-1-git-send-email-hechtb+renesas@gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Fri, Dec 14, 2012 at 12:20:29PM +0900, Magnus Damm wrote: > On Thu, Dec 6, 2012 at 9:08 PM, Bastian Hecht wrote: > > From: Bastian Hecht > > > > When booting secondary CPUs we have used the main CPU to set up the > > Snoop Control Unit flags of these CPUs. It is a cleaner approach > > if every CPU takes care of its own flags. We avoid the need for > > locking and the program logic is more concise. With this patch the file > > headsmp-sh73a0.S is added that contains a startup vector for secondary CPUs > > that sets up its own SCU flags. > > Further in sh73a0_smp_prepare_cpus() we can rely on the generic ARM helper > > scu_power_mode(). This is possible as we don't cross borders anymore (every > > CPU handles its own flags) and need no locking. So we can throw out the > > needless function modify_scu_cpu_psr(). > > > > Signed-off-by: Bastian Hecht > > Acked-by: Magnus Damm Hi Bastian, could you please re-spin this series on top of the soc5 or next branches of my renesas tree on kernel.org? Feel free to include Magnus's Ack unless you make any non-trivial changes. Thanks:wq