From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Tue, 18 Dec 2012 00:31:50 +0000 Subject: Re: [PATCH 02/10] SH: intc: Add support OF of IRQ Message-Id: <20121218003150.GH7146@verge.net.au> List-Id: References: <1355562224-29448-1-git-send-email-horms+renesas@verge.net.au> <1355562224-29448-3-git-send-email-horms+renesas@verge.net.au> <2838757.yMqfipzqR7@avalon> In-Reply-To: <2838757.yMqfipzqR7@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Mon, Dec 17, 2012 at 09:29:44AM +0100, Laurent Pinchart wrote: > Hi Iwamatsu-san, > > Thank your for the patch. > > On Saturday 15 December 2012 18:03:36 Simon Horman wrote: > > From: Nobuhiro Iwamatsu > > > > Add information of device node to struct intc_desc. > > > > Cc: Magnus Damm > > Signed-off-by: Nobuhiro Iwamatsu > > Signed-off-by: Simon Horman > > > > --- > > > > v7 > > * Delete "renesas,sh_intcs" and "renesas,sh_intca_irq_pins" as compatible. > > Update their documentation. > > * Remove of_sh_intc_get_meminfo() and of_sh_intc_get_pint and > > of_sh_intc_get_intc(). They are not used. > > > > v2 - v6 > > * No change > > --- > > Documentation/devicetree/bindings/sh/intc.txt | 15 +---- > > drivers/sh/intc/core.c | 2 +- > > drivers/sh/intc/internals.h | 3 +- > > drivers/sh/intc/irqdomain.c | 6 +- > > drivers/sh/intc/of_intc.c | 76 ---------------------- > > include/linux/sh_intc.h | 29 +--------- > > 6 files changed, 9 insertions(+), 122 deletions(-) > > Shouldn't this be squashed into patch 01/10 ? 01/10 adds DT bindings support, > and you already modify them in this patch. Good point. Yes, I think so. I'll probably be the one doing the squashing and if so I'll do so for the next spin.