* [PATCH] ARM: shmobile: kzm9g: Use of_machine_is_compatible()
@ 2013-01-03 18:14 Laurent Pinchart
2013-01-07 2:22 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Pinchart @ 2013-01-03 18:14 UTC (permalink / raw)
To: linux-sh
The machine number is hardcoded to ~0 on DT-enabled machines, making
machine_is_*() always fail when support for more than one machine is
compiled into the kernel. Replace the machine_is_kzm9g() call with
of_machine_is_compatible("renesas,kzm9g").
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
arch/arm/mach-shmobile/board-kzm9g.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Without this patch the backlight is never turned on on the kzm9g board if
support for more than one machine is compiled into the kernel.
diff --git a/arch/arm/mach-shmobile/board-kzm9g.c b/arch/arm/mach-shmobile/board-kzm9g.c
index c02448d..eadf309 100644
--- a/arch/arm/mach-shmobile/board-kzm9g.c
+++ b/arch/arm/mach-shmobile/board-kzm9g.c
@@ -623,7 +623,7 @@ static int __init as3711_enable_lcdc_backlight(void)
0x45, 0xf0,
};
- if (!machine_is_kzm9g())
+ if (!of_machine_is_compatible("renesas,kzm9g"))
return 0;
if (!a)
--
Regards,
Laurent Pinchart
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: shmobile: kzm9g: Use of_machine_is_compatible()
2013-01-03 18:14 [PATCH] ARM: shmobile: kzm9g: Use of_machine_is_compatible() Laurent Pinchart
@ 2013-01-07 2:22 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2013-01-07 2:22 UTC (permalink / raw)
To: linux-sh
On Thu, Jan 03, 2013 at 07:14:17PM +0100, Laurent Pinchart wrote:
> The machine number is hardcoded to ~0 on DT-enabled machines, making
> machine_is_*() always fail when support for more than one machine is
> compiled into the kernel. Replace the machine_is_kzm9g() call with
> of_machine_is_compatible("renesas,kzm9g").
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Thanks, I have applied this to the boards branch.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-01-07 2:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-03 18:14 [PATCH] ARM: shmobile: kzm9g: Use of_machine_is_compatible() Laurent Pinchart
2013-01-07 2:22 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).