linux-sh.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] sh: define TASK_UNMAPPED_BASE as a page aligned constant
@ 2013-01-11  4:17 Kuninori Morimoto
  2013-01-11  5:05 ` Michel Lespinasse
  2013-01-11 10:23 ` Paul Mundt
  0 siblings, 2 replies; 3+ messages in thread
From: Kuninori Morimoto @ 2013-01-11  4:17 UTC (permalink / raw)
  To: linux-sh

b4265f12340f809447b9a48055e88c444b480c89
(mm: use vm_unmapped_area() on sh architecture)
broke sh boot. This patch define TASK_UNMAPPED_BASE
as a page aligned constant to solve this issue.
Special thanks to Michel

Cc: Michel Lespinasse <walken@google.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---

>> Michel

Thanks !!
my board start works with this patch.
Please check it.

 arch/sh/include/asm/processor_32.h |    2 +-
 arch/sh/include/asm/processor_64.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/sh/include/asm/processor_32.h b/arch/sh/include/asm/processor_32.h
index b6311fd..379a407 100644
--- a/arch/sh/include/asm/processor_32.h
+++ b/arch/sh/include/asm/processor_32.h
@@ -39,7 +39,7 @@
 /* This decides where the kernel will search for a free chunk of vm
  * space during mmap's.
  */
-#define TASK_UNMAPPED_BASE	(TASK_SIZE / 3)
+#define TASK_UNMAPPED_BASE	PAGE_ALIGN(TASK_SIZE / 3)
 
 /*
  * Bit of SR register
diff --git a/arch/sh/include/asm/processor_64.h b/arch/sh/include/asm/processor_64.h
index cd6029f..670891d 100644
--- a/arch/sh/include/asm/processor_64.h
+++ b/arch/sh/include/asm/processor_64.h
@@ -47,7 +47,7 @@ pc; })
 /* This decides where the kernel will search for a free chunk of vm
  * space during mmap's.
  */
-#define TASK_UNMAPPED_BASE	(TASK_SIZE / 3)
+#define TASK_UNMAPPED_BASE	PAGE_ALIGN(TASK_SIZE / 3)
 
 /*
  * Bit of SR register
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] sh: define TASK_UNMAPPED_BASE as a page aligned constant
  2013-01-11  4:17 [PATCH] sh: define TASK_UNMAPPED_BASE as a page aligned constant Kuninori Morimoto
@ 2013-01-11  5:05 ` Michel Lespinasse
  2013-01-11 10:23 ` Paul Mundt
  1 sibling, 0 replies; 3+ messages in thread
From: Michel Lespinasse @ 2013-01-11  5:05 UTC (permalink / raw)
  To: linux-sh

On Thu, Jan 10, 2013 at 8:17 PM, Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> b4265f12340f809447b9a48055e88c444b480c89
> (mm: use vm_unmapped_area() on sh architecture)
> broke sh boot. This patch define TASK_UNMAPPED_BASE
> as a page aligned constant to solve this issue.
> Special thanks to Michel
>
> Cc: Michel Lespinasse <walken@google.com>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Acked-by: Michel Lespinasse <walken@google.com>

> Thanks !!
> my board start works with this patch.
> Please check it.

Looks fine, thanks for finding this :)

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] sh: define TASK_UNMAPPED_BASE as a page aligned constant
  2013-01-11  4:17 [PATCH] sh: define TASK_UNMAPPED_BASE as a page aligned constant Kuninori Morimoto
  2013-01-11  5:05 ` Michel Lespinasse
@ 2013-01-11 10:23 ` Paul Mundt
  1 sibling, 0 replies; 3+ messages in thread
From: Paul Mundt @ 2013-01-11 10:23 UTC (permalink / raw)
  To: linux-sh

On Thu, Jan 10, 2013 at 09:05:34PM -0800, Michel Lespinasse wrote:
> On Thu, Jan 10, 2013 at 8:17 PM, Kuninori Morimoto
> <kuninori.morimoto.gx@renesas.com> wrote:
> > b4265f12340f809447b9a48055e88c444b480c89
> > (mm: use vm_unmapped_area() on sh architecture)
> > broke sh boot. This patch define TASK_UNMAPPED_BASE
> > as a page aligned constant to solve this issue.
> > Special thanks to Michel
> >
> > Cc: Michel Lespinasse <walken@google.com>
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> Acked-by: Michel Lespinasse <walken@google.com>
> 
> > Thanks !!
> > my board start works with this patch.
> > Please check it.
> 
> Looks fine, thanks for finding this :)
> 
Thanks guys, I'll queue it up.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-01-11 10:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-11  4:17 [PATCH] sh: define TASK_UNMAPPED_BASE as a page aligned constant Kuninori Morimoto
2013-01-11  5:05 ` Michel Lespinasse
2013-01-11 10:23 ` Paul Mundt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).