From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva
Date: Wed, 13 Feb 2013 07:30:10 +0000 [thread overview]
Message-ID: <20130213073006.GA14793@verge.net.au> (raw)
In-Reply-To: <1360689333-13525-3-git-send-email-g.liakhovetski@gmx.de>
On Tue, Feb 12, 2013 at 04:53:51PM -0800, Kuninori Morimoto wrote:
>
> Hi Guennadi
>
> > When regulators are used with MMC devices, explicitly provided OCR masks
> > are ignored, they can be removed from platform data. Also switch SDHI0
> > from fixed regulator with hard-wired GPIO levels to a proper GPIO regulator
> > instance to enable dynamic voltage switching.
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > ---
>
> I got "checkpatch.pl" warning on this patch.
> I don't care so much about "Avoid CamelCase",
> but please fix "line over 80 characters" and "{" position.
It seems that with this change in place it would also be good
to update the defconfig to enable CONFIG_REGULATOR and possibly
CONFIG_REGULATOR_DUMMY.
Guennadi could you make a separate patch to do this?
next prev parent reply other threads:[~2013-02-13 7:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 17:15 [PATCH 2/3] ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva Guennadi Liakhovetski
2013-02-13 0:53 ` Kuninori Morimoto
2013-02-13 7:30 ` Simon Horman [this message]
2013-02-13 7:33 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213073006.GA14793@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox