From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 4/8] ARM: shmobile: move GIC and I2C devices from sh73a0 common .dtsi to reference
Date: Wed, 13 Feb 2013 11:36:38 +0000 [thread overview]
Message-ID: <20130213113637.GH22623@verge.net.au> (raw)
In-Reply-To: <1360348712-29255-5-git-send-email-g.liakhovetski@gmx.de>
On Wed, Feb 13, 2013 at 10:59:41AM +0100, Guennadi Liakhovetski wrote:
> Hi Simon
>
> On Wed, 13 Feb 2013, Simon Horman wrote:
>
> > On Fri, Feb 08, 2013 at 07:38:28PM +0100, Guennadi Liakhovetski wrote:
> > > In "legacy" mode, when all devices are initialised by the board .c file,
> > > there is no need to install the GIC and all I2C devices from the device
> > > tree too. Move them to the reference implementation, that fully relies upon
> > > DT.
> >
> > The motivation for placing the code in sh73a0.dtsi was so that
> > it would be available to the non-reference board code if/when it
> > moves over to using DT.
> >
> > I'm happy to switch things around if its preferred to keep
> > the dts small.
>
> As I said, I do think it is good to keep devices in a central .dtsi,
> included by all, but they should be disabled by default, using the
> 'status="disabled"' property, and only enabled on boards, that actually
> use those devices.
Ok, that makes sense to me. Do you think you could update this patch
accordingly?
> I'm just not sure what's the difference between the two
> DT-"patching" syntaxes - using '&' and not using it.
Unfortunately I'm not sure either.
> Thanks
> Guennadi
>
> > > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> > > ---
> > >
> > > I think, this is a fix and should be applied.
> > >
> > > arch/arm/boot/dts/sh73a0-reference.dtsi | 69 +++++++++++++++++++++++++++++++
> > > arch/arm/boot/dts/sh73a0.dtsi | 69 -------------------------------
> > > 2 files changed, 69 insertions(+), 69 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/sh73a0-reference.dtsi b/arch/arm/boot/dts/sh73a0-reference.dtsi
> > > index d4bb012..457afc7 100644
> > > --- a/arch/arm/boot/dts/sh73a0-reference.dtsi
> > > +++ b/arch/arm/boot/dts/sh73a0-reference.dtsi
> > > @@ -21,4 +21,73 @@
> > > 0 141 0x4>;
> > > reg-io-width = <4>;
> > > };
> > > +
> > > + gic: interrupt-controller@f0001000 {
> > > + compatible = "arm,cortex-a9-gic";
> > > + #interrupt-cells = <3>;
> > > + #address-cells = <1>;
> > > + interrupt-controller;
> > > + reg = <0xf0001000 0x1000>,
> > > + <0xf0000100 0x100>;
> > > + };
> > > +
> > > + i2c0: i2c@0xe6820000 {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + compatible = "renesas,rmobile-iic";
> > > + reg = <0xe6820000 0x425>;
> > > + interrupt-parent = <&gic>;
> > > + interrupts = <0 167 0x4
> > > + 0 168 0x4
> > > + 0 169 0x4
> > > + 0 170 0x4>;
> > > + };
> > > +
> > > + i2c1: i2c@0xe6822000 {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + compatible = "renesas,rmobile-iic";
> > > + reg = <0xe6822000 0x425>;
> > > + interrupt-parent = <&gic>;
> > > + interrupts = <0 51 0x4
> > > + 0 52 0x4
> > > + 0 53 0x4
> > > + 0 54 0x4>;
> > > + };
> > > +
> > > + i2c2: i2c@0xe6824000 {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + compatible = "renesas,rmobile-iic";
> > > + reg = <0xe6824000 0x425>;
> > > + interrupt-parent = <&gic>;
> > > + interrupts = <0 171 0x4
> > > + 0 172 0x4
> > > + 0 173 0x4
> > > + 0 174 0x4>;
> > > + };
> > > +
> > > + i2c3: i2c@0xe6826000 {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + compatible = "renesas,rmobile-iic";
> > > + reg = <0xe6826000 0x425>;
> > > + interrupt-parent = <&gic>;
> > > + interrupts = <0 183 0x4
> > > + 0 184 0x4
> > > + 0 185 0x4
> > > + 0 186 0x4>;
> > > + };
> > > +
> > > + i2c4: i2c@0xe6828000 {
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + compatible = "renesas,rmobile-iic";
> > > + reg = <0xe6828000 0x425>;
> > > + interrupt-parent = <&gic>;
> > > + interrupts = <0 187 0x4
> > > + 0 188 0x4
> > > + 0 189 0x4
> > > + 0 190 0x4>;
> > > + };
> > > };
> > > diff --git a/arch/arm/boot/dts/sh73a0.dtsi b/arch/arm/boot/dts/sh73a0.dtsi
> > > index 8a59465..6837b3f 100644
> > > --- a/arch/arm/boot/dts/sh73a0.dtsi
> > > +++ b/arch/arm/boot/dts/sh73a0.dtsi
> > > @@ -28,73 +28,4 @@
> > > reg = <1>;
> > > };
> > > };
> > > -
> > > - gic: interrupt-controller@f0001000 {
> > > - compatible = "arm,cortex-a9-gic";
> > > - #interrupt-cells = <3>;
> > > - #address-cells = <1>;
> > > - interrupt-controller;
> > > - reg = <0xf0001000 0x1000>,
> > > - <0xf0000100 0x100>;
> > > - };
> > > -
> > > - i2c0: i2c@0xe6820000 {
> > > - #address-cells = <1>;
> > > - #size-cells = <0>;
> > > - compatible = "renesas,rmobile-iic";
> > > - reg = <0xe6820000 0x425>;
> > > - interrupt-parent = <&gic>;
> > > - interrupts = <0 167 0x4
> > > - 0 168 0x4
> > > - 0 169 0x4
> > > - 0 170 0x4>;
> > > - };
> > > -
> > > - i2c1: i2c@0xe6822000 {
> > > - #address-cells = <1>;
> > > - #size-cells = <0>;
> > > - compatible = "renesas,rmobile-iic";
> > > - reg = <0xe6822000 0x425>;
> > > - interrupt-parent = <&gic>;
> > > - interrupts = <0 51 0x4
> > > - 0 52 0x4
> > > - 0 53 0x4
> > > - 0 54 0x4>;
> > > - };
> > > -
> > > - i2c2: i2c@0xe6824000 {
> > > - #address-cells = <1>;
> > > - #size-cells = <0>;
> > > - compatible = "renesas,rmobile-iic";
> > > - reg = <0xe6824000 0x425>;
> > > - interrupt-parent = <&gic>;
> > > - interrupts = <0 171 0x4
> > > - 0 172 0x4
> > > - 0 173 0x4
> > > - 0 174 0x4>;
> > > - };
> > > -
> > > - i2c3: i2c@0xe6826000 {
> > > - #address-cells = <1>;
> > > - #size-cells = <0>;
> > > - compatible = "renesas,rmobile-iic";
> > > - reg = <0xe6826000 0x425>;
> > > - interrupt-parent = <&gic>;
> > > - interrupts = <0 183 0x4
> > > - 0 184 0x4
> > > - 0 185 0x4
> > > - 0 186 0x4>;
> > > - };
> > > -
> > > - i2c4: i2c@0xe6828000 {
> > > - #address-cells = <1>;
> > > - #size-cells = <0>;
> > > - compatible = "renesas,rmobile-iic";
> > > - reg = <0xe6828000 0x425>;
> > > - interrupt-parent = <&gic>;
> > > - interrupts = <0 187 0x4
> > > - 0 188 0x4
> > > - 0 189 0x4
> > > - 0 190 0x4>;
> > > - };
> > > };
> > > --
> > > 1.7.2.5
> > >
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > >
> >
>
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sh" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2013-02-13 11:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-08 18:38 [PATCH v2 4/8] ARM: shmobile: move GIC and I2C devices from sh73a0 common .dtsi to reference Guennadi Liakhovetski
2013-02-13 3:39 ` Simon Horman
2013-02-13 9:59 ` Guennadi Liakhovetski
2013-02-13 11:36 ` Simon Horman [this message]
2013-03-19 11:25 ` Guennadi Liakhovetski
2013-03-19 12:14 ` Simon Horman
2013-03-19 12:24 ` Simon Horman
2013-03-19 12:49 ` Guennadi Liakhovetski
2013-03-19 12:55 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213113637.GH22623@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox