From: Simon Horman <horms@verge.net.au>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: shmobile: r8a7779: Correct TMU clock support again
Date: Thu, 14 Feb 2013 04:42:22 +0000 [thread overview]
Message-ID: <20130214044221.GB4773@verge.net.au> (raw)
In-Reply-To: <20130214043648.GA4773@verge.net.au>
On Thu, Feb 14, 2013 at 01:36:49PM +0900, Simon Horman wrote:
> On Wed, Feb 13, 2013 at 08:25:45PM -0800, Kuninori Morimoto wrote:
> >
> > Hi Simon
> >
> > > > >> CLKDEV_DEV_ID("sh_tmu.0", &mstp_clks[MSTP016]), /* TMU00 */
> > > > >> - CLKDEV_DEV_ID("sh_tmu.1", &mstp_clks[MSTP015]), /* TMU01 */
> > > > >> + CLKDEV_DEV_ID("sh_tmu.1", &mstp_clks[MSTP016]), /* TMU01 */
> > > > >> CLKDEV_DEV_ID("sh_tmu.2", &mstp_clks[MSTP014]), /* TMU02 */
> > (snip)
> > > > This means that current TMU02 numbering seems doubtful too ?
> > > > How about just rever 58079fa7d54a0929d304054ee759187a2ccd3cdf ?
> > >
> > > Perhaps that is a good idea.
> > >
> > > The original motivation for this patch was to add the TMU02 line.
> > > And "fixing" TMU01 was an afterthought. However, I am also
> > > now doubtful about the correctness of the TMU02 line and thus
> > > the usefulness of the original patch.
> >
> > I think this comment out is creating confusion ?
> >
> > /* TMU00 */ -> /* TMU0 channel 0 */
> > /* TMU01 */ -> /* TMU0 channel 1 */
> > /* TMU02 */ -> /* TMU0 channel 2 */
>
> That does make things a little clearer,
> but I for one wasn't confused by the existing comments.
Ok, now I think I see what you are getting at.
MSTP016 is for channel 0..n of TMU0
MSTP015 is for channel 1..n of TMU1
MSTP014 is for channel 2..n of TMU2
And all the TMU values set by CLKDEV_DEV_ID statements above
relate to channels of TMU0.
That does seem to be a valid interpretation of the documentation
now that I read it again.
next prev parent reply other threads:[~2013-02-14 4:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 3:28 [PATCH] ARM: shmobile: r8a7779: Correct TMU clock support Simon Horman
2013-02-05 3:30 ` Magnus Damm
2013-02-14 3:43 ` [PATCH] ARM: shmobile: r8a7779: Correct TMU clock support again Simon Horman
2013-02-14 4:03 ` Kuninori Morimoto
2013-02-14 4:04 ` Magnus Damm
2013-02-14 4:12 ` Kuninori Morimoto
2013-02-14 4:14 ` Kuninori Morimoto
2013-02-14 4:20 ` Simon Horman
2013-02-14 4:25 ` Kuninori Morimoto
2013-02-14 4:36 ` Simon Horman
2013-02-14 4:42 ` Simon Horman [this message]
2013-02-14 5:20 ` Magnus Damm
2013-02-14 8:34 ` Simon Horman
2013-02-14 4:16 ` Simon Horman
2013-02-14 9:10 ` Paul Mundt
2013-02-14 16:08 ` Simon Horman
2013-02-14 16:18 ` Paul Mundt
2013-02-15 13:53 ` Simon Horman
2013-02-18 0:52 ` Simon Horman
2013-02-15 13:35 ` Simon Horman
-- strict thread matches above, loose matches on Subject: below --
2013-02-19 3:49 [GIT PULL] Renesas ARM-based SoC for v3.9 #5 Simon Horman
2013-02-19 3:49 ` [PATCH] ARM: shmobile: r8a7779: Correct TMU clock support again Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130214044221.GB4773@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).