From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Date: Thu, 14 Feb 2013 08:36:19 +0000 Subject: Re: [PATCH 2/3] ARM: mach-shmobile: armadillo800eva: enable REGULATOR in defconfig Message-Id: <20130214083619.GC21198@verge.net.au> List-Id: References: <1360761103-17357-1-git-send-email-horms+renesas@verge.net.au> <1360761103-17357-3-git-send-email-horms+renesas@verge.net.au> <20130214024847.GQ15879@verge.net.au> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On Thu, Feb 14, 2013 at 08:49:34AM +0100, Guennadi Liakhovetski wrote: > Hi Simon > > On Thu, 14 Feb 2013, Simon Horman wrote: > > > On Wed, Feb 13, 2013 at 10:11:42PM +0900, Simon Horman wrote: > > > As well as being a generally sane thing to do this > > > is required for MMCIF to function in conjunction with > > > "ARM: shmobile: switch SDHI0 to GPIO regulator on armadillo800eva". > > > > > > Cc: Guennadi Liakhovetski > > > Signed-off-by: Simon Horman > > > > > > --- > > > > > > v2 > > > * Don't enable REGULATOR_DUMMY, it is only intended for development / testing. > > > --- > > > arch/arm/configs/armadillo800eva_defconfig | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/arch/arm/configs/armadillo800eva_defconfig b/arch/arm/configs/armadillo800eva_defconfig > > > index 0b98100..0cc8014 100644 > > > --- a/arch/arm/configs/armadillo800eva_defconfig > > > +++ b/arch/arm/configs/armadillo800eva_defconfig > > > @@ -88,6 +88,7 @@ CONFIG_I2C=y > > > CONFIG_I2C_GPIO=y > > > CONFIG_I2C_SH_MOBILE=y > > > # CONFIG_HWMON is not set > > > +CONFIG_REGULATOR=y > > > CONFIG_MEDIA_SUPPORT=y > > > CONFIG_VIDEO_DEV=y > > > CONFIG_MEDIA_CAMERA_SUPPORT=y > > > > This patch seems to break NIC initialisation. > > > > smsc911x: Driver version 2008-10-21 > > smsc911x smsc911x.0: Failed to get supply 'vdd33a': -517 > > smsc911x smsc911x.0 (unregistered net_device): couldn't get regulators -517 > > platform smsc911x.0: Driver smsc911x requests probe deferral Sorry, I replied to the wrong patch. It was on KZM9G that I observed this. It seems to need REGULATOR_DUMMY.