From: Simon Horman <horms@verge.net.au>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] ARM: shmobile: r8a7779: fixup of_platform.h compile warning
Date: Fri, 01 Mar 2013 07:09:23 +0000 [thread overview]
Message-ID: <20130301070923.GC14376@verge.net.au> (raw)
In-Reply-To: <87y5ekelc9.wl%kuninori.morimoto.gx@renesas.com>
On Tue, Feb 19, 2013 at 06:29:53PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 19-02-2013 12:53, Kuninori Morimoto wrote:
>
> >This patch fixup below warning
>
> >CC arch/arm/mach-shmobile/setup-r8a7779.o
> >In file included from ${LINUX}/arch/arm/mach-shmobile/setup-r8a7779.c:25:0:
> >${LINUX}/include/linux/of_platform.h:107:13:
> > warning: 'struct of_device_id' declared inside
> > parameter list [enabled by default]
> >${LINUX}/include/linux/of_platform.h:107:13:
> > warning: its scope is only this definition or declaration,
> > which is probably not what you want [enabled by default]
> >${LINUX}/include/linux/of_platform.h:107:13:
> > warning: 'struct device_node' declared inside
> > parameter list [enabled by default]
>
> >Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >---
> >>>Simon
>
> >This is based on simon/soc5 branch
>
> > arch/arm/mach-shmobile/setup-r8a7779.c | 1 +
> > 1 file changed, 1 insertion(+)
>
> >diff --git a/arch/arm/mach-shmobile/setup-r8a7779.c b/arch/arm/mach-shmobile/setup-r8a7779.c
> >index 7b4c1eb8..5911c04 100644
> >--- a/arch/arm/mach-shmobile/setup-r8a7779.c
> >+++ b/arch/arm/mach-shmobile/setup-r8a7779.c
> >@@ -21,6 +21,7 @@
> > #include <linux/init.h>
> > #include <linux/interrupt.h>
> > #include <linux/irq.h>
> >+#include <linux/of.h>
> > #include <linux/of_platform.h>
> > #include <linux/platform_device.h>
> > #include <linux/delay.h>
>
> I think this is only papering over the issue which lies within a
> header file <linux/oh_platform.h> itself. Exactly this file needs
> fixing -- which I tried to do in my patch posted somewhat earlier:
>
> http://marc.info/?l=linux-sh&m\x136122828108385
Thanks, I agree with your analysis.
prev parent reply other threads:[~2013-03-01 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 8:53 [PATCH] ARM: shmobile: r8a7779: fixup of_platform.h compile warning Kuninori Morimoto
2013-02-19 14:29 ` Sergei Shtylyov
2013-03-01 7:09 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130301070923.GC14376@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox